Skip to content

Add license header text to all modules and subworkflow main.nf files - #13448

Merged
matthdsm merged 6 commits into
masterfrom
add-license-header-text
Oct 27, 2026
Merged

matthdsm merged 6 commits into
masterfrom
add-license-header-text

Conversation

@jfy133

@jfy133 jfy133 commented Oct 23, 2026

Copy link
Copy Markdown
Member

Partly addresses nf-core/tools#4510

replaces #13118 without autoformatting

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@github-actions

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@pontus

pontus commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

There's a final extra space on the first line of each file that I think shouldn't be there.

@jfy133

jfy133 commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

GAH!!!

will fix later this afternoon, sorry - I completely didn't see it 🤦🏼‍♀️

@jfy133
jfy133 requested a review from pontus October 26, 2026 16:02

@pontus pontus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold for 24 hours ;)

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, happy if we want to do this.

@jfy133
jfy133 enabled auto-merge October 27, 2026 17:33
@matthdsm
matthdsm disabled auto-merge October 27, 2026 20:05
@matthdsm
matthdsm merged commit 7b3452a into master Oct 27, 2026
4 of 5 checks passed
@matthdsm
matthdsm deleted the add-license-header-text branch October 27, 2026 20:05
@matthdsm

Copy link
Copy Markdown
Contributor

Force merged per request on slack by @jfy133 , co-approved by @maxulysse

@Lukecele Lukecele mentioned this pull request Oct 27, 2026
6 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants