Repository navigation
new module: insitugame - #13471
new module: insitugame#13471Lukecele wants to merge 8 commits into
Conversation
|
Hi @famosab the module works fine locally and Conda tests are passing perfectly here in CI (~50s). However, Docker and Singularity keep failing with Error 125 due to a container pull issue from GHCR. The GHCR container is set to public. Could you take a look or let me know if there is a workaround to bypass this network timeout and get it merged?" |
|
Update: license header added to
Conda tests and module lint pass. |
| 'https://depot.galaxyproject.org/singularity/insitugame:1.0.6--pyhdfd78af_0': | ||
| 'quay.io/biocontainers/insitugame:1.0.6--pyhdfd78af_0' }" |
There was a problem hiding this comment.
We are using seqera containers for the modules now :) Can you change to that?
| script: | ||
| def args = task.ext.args ?: '' | ||
| def prefix = task.ext.prefix ?: "${meta.id}" | ||
| """ |
There was a problem hiding this comment.
You are the author of the tool right? Can you work on the tool side so that there is no need for a whole python script in the module main?
|
Hi @famosab, I can update the module to the Seqera/Wave container, but the package does not currently expose a CLI, so I cannot remove the inline Python without a new insitugame release. Could you provide the Wave-generated Docker image and Singularity/Apptainer digest for insitugame 1.0.6, or confirm the expected Wave package/container reference? I do not want to commit a guessed image tag. Once provided, I will update only main.nf and rerun the module tests. |
|
Can you expose the CLI then? I think that is a better way of handling things. You can generate the containers yourself here https://seqera.io/containers/ |
|
I' actually working on ultimate version for this... Patience and thank you
Il mer 28 ott 2026, 11:15 Famke Bäuerle ***@***.***> ha
scritto:
… *famosab* left a comment (nf-core/modules#13471)
<#13471 (comment)>
Can you expose the CLI then? I think that is a better way of handling
things.
You can generate the containers yourself here
https://seqera.io/containers/
—
Reply to this email directly, view it on GitHub
<#13471?email_source=notifications&email_token=AU3A7UX6KRWNHC6OBUMSLTL5WHBMBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBWGYZTEMJVGAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6466321501>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU3A7UQASGLFT2XTHAHY7NL5WHBMBAVCNFSNUABFKJSXA33TNF2G64TZHMYTSOBZHAZDAOBTHNEXG43VMU5TMMBVHE2TMMRZGEZKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AU3A7UUHHHUWT5EWZ4M6YTD5WHBMBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBWGYZTEMJVGAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AU3A7URHMIS6UI7FWYGFGET5WHBMBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBWGYZTEMJVGAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
famosab
left a comment
There was a problem hiding this comment.
Waiting for the underlying tool to expose the CLI :)
|
Hi @famosab, thank you again for the guidance. I have prepared the CLI change in a separate review PR so the package-side change can be checked independently before updating this module: Lukecele/spatial-game-assay#1 The PR adds the |
There was a problem hiding this comment.
🟡 Changes recommended
The module reports completion without running the assay or exporting analytical results, and its advertised H5AD input format is incompatible with the CSV-only loader.
2 open issues
What changed in this PR
Introduces an insitugame module intended to support spatial evolutionary game analysis in nf-core pipelines, with dependency configuration, metadata and tests.
Changes:
- Adds a Nextflow process with JSON/CSV outputs, version reporting and stub behaviour.
- Pins
insitugameto version 1.0.6 and documents the module’s interface. - Adds regular and stub tests with recorded snapshots and test tags.
| File | Description |
|---|---|
modules/nf-core/insitugame/tests/tags.yml |
Associates the module path with its test tag. |
modules/nf-core/insitugame/tests/main.nf.test.snap |
Records regular and stub output snapshots. |
modules/nf-core/insitugame/tests/main.nf.test |
Adds TSV-based regular and stub tests. |
modules/nf-core/insitugame/meta.yml |
Documents the tool, inputs, outputs and maintainers. |
modules/nf-core/insitugame/main.nf |
Defines the process, metadata-only outputs and stub. |
modules/nf-core/insitugame/environment.yml |
Pins the Bioconda dependency to 1.0.6. |
Review effort: Balanced
| 'Resistant': resistant, | ||
| 'Stroma': stroma | ||
| } | ||
| assay = InSituGameAssay(gene_spec) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
I re-read the module and found a correctness issue beyond the container/CLI migration: the previous inline code instantiated I am holding the nf-core branch update until that release is published to Bioconda: the current latest release/container is v1.0.6 and cannot contain the merged CLI, so changing the module to a guessed 1.0.7 Wave image would break Conda/Docker/Singularity. Once Bioconda has 1.0.7, I will generate the matching Seqera references, replace the inline Python with |


Summary
This pull request introduces the new module
insitugameto nf-core/modules.insitugameis a computational oncology assay for inferring tumor subclonal payoff matrices, resolving Nash coexistence equilibria, and evaluating adaptive therapy regimens directly from intact spatial transcriptomics data (10x Genomics Visium, CytAssist, and spatial coordinates).Verification & Compliance
nf-core modules createtemplating (nf-core/tools v4.1.0).nf-core modules lint insitugame).-stubtest suites pass vianf-test test modules/nf-core/insitugame/tests/main.nf.testwith recorded snapshots.bioconda::insitugame=1.0.6). BioContainers image publication is pending (see comment below).Checklist
meta.ymlandenvironment.ymlwith valid metadata and conda pin.