Skip to content

feat(preference): Allow apps to prevent admins from corrupting preferences via command line - #66034

Open
nickvergessen wants to merge 2 commits into
masterfrom
feat/noid/preference-validation
Open

feat(preference): Allow apps to prevent admins from corrupting preferences via command line#66034
nickvergessen wants to merge 2 commits into
masterfrom
feat/noid/preference-validation

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Oct 30, 2026

Copy link
Copy Markdown
Member

Assisted-by: ClaudeCode:claude-opus-5-5

Summary

  • In various cases user preferences are "magic values", e.g. talk has conversation list styles saved there and only valid values are compact or two-lines. This is correctly checked with BeforePreferenceSetEvent when a user sets it via provisioning_api API endpoints. However an admin can still way too easy/accidentally corrupt the entries via occ user:setting.
  • The change of this PR allows apps to also block it on that level. To be non-breaking, the check is relaxed on OCC calls to only block when explicitly denied.
  • Apps still should validate the issue, but at least an admin is notified when they tried to set an invalid value.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nickvergessen
feat(preference): Allow apps to prevent admins from corrupting prefer…
c3d0d83 
…ences via command line

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 36 milestone Oct 30, 2026
@nickvergessen nickvergessen self-assigned this Oct 30, 2026
@nickvergessen nickvergessen added 3. to review Waiting for reviews feature: settings feature: occ php Pull requests that update Php code AI assisted labels Oct 30, 2026
@nickvergessen
nickvergessen requested a review from a team as a code owner October 30, 2026 09:38
@nickvergessen
nickvergessen requested review from CarlSchwan, icewind1991, leftybournes and provokateurin and removed request for a team October 30, 2026 09:38
@nickvergessen nickvergessen mentioned this pull request Oct 30, 2026
Open
7 tasks done
@nickvergessen
feat(preference): Add option to still force-fully set a value
ba12e1b 
Signed-off-by: Joas Schilling <coding@schilljs.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudormant sudormant sudormant approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews AI assisted enhancement feature: occ feature: settings php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen @sudormant