Repository navigation
feat(appconfig): Allow apps to validate/reject setting values via provisioning_api and occ - #66035
Open
nickvergessen wants to merge 3 commits into
Open
nickvergessen wants to merge 3 commits into
nickvergessen wants to merge 3 commits into
Conversation
…visioning_api and occ Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
a team,
Altahrim,
CarlSchwan,
leftybournes and
sudormant
and removed request for
a team
October 30, 2026 09:51
Signed-off-by: Joas Schilling <coding@schilljs.com>
sudormant
approved these changes
Oct 30, 2026
Member
|
not doable deeper in the AppConfig API ? |
Member
Author
I actually don't want to do it inside there intentionally, so that apps can still temper with their own data and don't have to check when the event is triggered, if they are the one calling it. E.g. follow up idea from me would be adding a listener in core that takes over this validation: server/apps/provisioning_api/lib/Controller/AppConfigController.php Lines 221 to 231 in 58a10e1 But e.g. the installed_version and others still need to be able to be set with core functionality |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ClaudeCode:claude-opus-5-5
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)