Skip to content

fix: scroll folder list to matched item on type-to-select #9765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rello wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

fix: scroll folder list to matched item on type-to-select #9765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/gui/folderstatusview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,14 @@
return rect;
}

void FolderStatusView::keyboardSearch(const QString &search)

Check warning on line 36 in src/gui/folderstatusview.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/folderstatusview.cpp:36:24 [readability-convert-member-functions-to-static] 

method 'keyboardSearch' can be made static
{
QTreeView::keyboardSearch(search);

Check warning on line 38 in src/gui/folderstatusview.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/folderstatusview.cpp:38:31 [cppcoreguidelines-init-variables] 

variable 'search' is not initialized

const auto index = currentIndex();
if (index.isValid()) {
scrollTo(index, QAbstractItemView::EnsureVisible);
}
}

} // namespace OCC
1 change: 1 addition & 0 deletions src/gui/folderstatusview.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#ifndef FOLDERSTATUSVIEW_H
#define FOLDERSTATUSVIEW_H

#include <QTreeView>

Check failure on line 9 in src/gui/folderstatusview.h

View workflow job for this annotation

GitHub Actions / build

src/gui/folderstatusview.h:9:10 [clang-diagnostic-error] 

'QTreeView' file not found

namespace OCC {

Expand All @@ -23,6 +23,7 @@

[[nodiscard]] QModelIndex indexAt(const QPoint &point) const override;
[[nodiscard]] QRect visualRect(const QModelIndex &index) const override;
void keyboardSearch(const QString &search) override;
};

} // namespace OCC
Expand Down
Loading