Set Input and NIRGraph input_type based on first nodes in graph#40
Merged
Conversation
Jegp
requested changes
Jul 4, 2025
Jegp
left a comment
Jegp
left a comment
Collaborator
There was a problem hiding this comment.
This looks great! Setting the input type explicitly is exactly by going through the edges is what needs to happen.
The only problem is that a lot of the tests are now failing :) Do you have time to fix this or can we be of help somehow?
fabio-innatera
force-pushed
the
infer-input-types
branch
from
d4381d4 to
5106e57
Compare
fabio-innatera
force-pushed
the
nir-update
branch
2 times, most recently
from
2e9131c to
7d78fb0
Compare
fabio-innatera
force-pushed
the
infer-input-types
branch
2 times, most recently
from
2d01887 to
7e388aa
Compare
fabio-innatera
force-pushed
the
infer-input-types
branch
from
7e388aa to
d301474
Compare
fabio-innatera
force-pushed
the
infer-input-types
branch
from
d301474 to
aa9f652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #38.
For the new type inference in NIR (neuromorphs/NIR#153) to work, we need valid types in the Input nodes. This is what this PR does.
We initialize both Input and Output types to None, then use the code in this PR to update them in Input after we constructed the graph, and finally let the type inference in NIR update the Output type.
This PR currently targets the nir-update branch, because the changes there are needed to make this work.
This also means all the checks will probably fail, because our CI uses the published NIR version.