Set Input and NIRGraph input_type based on first nodes in graph#38
Closed
fabio-innatera wants to merge 1 commit into
Closed
Set Input and NIRGraph input_type based on first nodes in graph#38fabio-innatera wants to merge 1 commit into
fabio-innatera wants to merge 1 commit into
Conversation
fabio-innatera
force-pushed
the
infer-input-types
branch
2 times, most recently
from
39b6ef9 to
6b79632
Compare
Jegp
requested changes
Jun 16, 2025
Jegp
left a comment
Jegp
left a comment
Collaborator
There was a problem hiding this comment.
Excellent changes, thank you.
As per our discussion, let's defer this to after the changes in NIR, where the type inference and type checking has been merged into one.
fabio-innatera
force-pushed
the
infer-input-types
branch
from
6b79632 to
84de8d4
Compare
Collaborator
Author
|
Replaced by #40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the discussion in #36.
The code in torch_tracer.py sets the input_type shape of the Input nodes to a dummy value (array[1]), this PR updates this value after the graph has been constructed and we know which nodes follow the input node.
My current idea is that type inference for the Input node happens here in NIRTorch, while the type inference for the Output node happens in NIR itself, in _forward_type_inference.
See neuromorphs/NIR#140 for that change.
Edit: Force push to format code with ruff, updated code comment.