Skip to content

Make test_iconv portable across iconv implementations #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tieske merged 4 commits into from
Sep 16, 2026
Merged

Make test_iconv portable across iconv implementations #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c9c0f7
Initial plan
Copilot Sep 16, 2026
6b74d1e
Comment out unsupported utf alias tests
Copilot Sep 16, 2026
89d9d0c
Apply suggestion from @Tieske
Tieske Sep 16, 2026
7302c4e
Merge branch 'master' into copilot/fix-test-iconv-failing-calls
Tieske Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test_iconv.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,12 @@ local function check_one(to, from, text)
end

check_one(termcs, "iso-8859-1", iso88591)
check_one(termcs, "utf8", utf8)
check_one(termcs, "utf16", utf16)
check_one(termcs, "utf-8", utf8)
check_one(termcs, "utf-16", utf16)
-- "utf-8" and "utf-16" are the official names; "utf8" and "utf16" are aliases
-- that are not supported by every iconv implementation.
-- check_one(termcs, "utf8", utf8)
-- check_one(termcs, "utf16", utf16)
Comment thread
Tieske marked this conversation as resolved.
check_one(termcs, "EBCDIC-CP-ES", ebcdic)


Expand Down
Loading