Repository navigation
Make test_iconv portable across iconv implementations - #24
Merged
Merged
Conversation
Co-authored-by: Tieske <1077043+Tieske@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test_iconv.lua missing hyphens for termux compatibility
Make test_iconv portable across iconv implementations that do not support utf8/utf16 aliases
Sep 16, 2026
Tieske
marked this pull request as ready for review
September 16, 2026 20:09
Tieske
reviewed
Sep 16, 2026
Member
|
@copilot rebase this PR |
Contributor
Author
Updated. I merged |
Copilot stopped work on behalf of
Tieske due to an error
September 16, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_iconv.luaassumedutf8andutf16aliases are universally accepted by the underlying iconv library. On Termux (and other implementations with stricter charset naming), those alias conversions fail despiteutf-8/utf-16support.utf8,utf16) that are not consistently supported across iconv implementations.utf-8/utf-16are the canonical names and non-hyphenated forms are implementation-dependent aliases.