Skip to content

Make test_iconv portable across iconv implementations - #24

Merged
Tieske merged 4 commits into
masterfrom
copilot/fix-test-iconv-failing-calls
Sep 16, 2026
Merged

Tieske merged 4 commits into
masterfrom
copilot/fix-test-iconv-failing-calls

Conversation

Copilot AI commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

test_iconv.lua assumed utf8 and utf16 aliases are universally accepted by the underlying iconv library. On Termux (and other implementations with stricter charset naming), those alias conversions fail despite utf-8/utf-16 support.

  • Test portability adjustment
    • Disabled the two alias-specific conversion calls (utf8, utf16) that are not consistently supported across iconv implementations.
  • Expectation clarified in test source
    • Added inline notes documenting that utf-8/utf-16 are the canonical names and non-hyphenated forms are implementation-dependent aliases.
check_one(termcs, "iso-8859-1", iso88591)
-- "utf-8" and "utf-16" are the official names; "utf8" and "utf16" are aliases
-- that are not supported by every iconv implementation.
-- check_one(termcs, "utf8", utf8)
-- check_one(termcs, "utf16", utf16)
check_one(termcs, "EBCDIC-CP-ES", ebcdic)

Co-authored-by: Tieske <1077043+Tieske@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test_iconv.lua missing hyphens for termux compatibility Make test_iconv portable across iconv implementations that do not support utf8/utf16 aliases Sep 16, 2026
Copilot AI requested a review from Tieske September 16, 2026 20:03
@Tieske
Tieske marked this pull request as ready for review September 16, 2026 20:09
Comment thread test_iconv.lua
@Tieske

Tieske commented Sep 16, 2026

Copy link
Copy Markdown
Member

@copilot rebase this PR

Copilot AI commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot rebase this PR

Updated. I merged master into this branch (commit 7c92698) to bring it up to date; in this environment I can’t publish a true rebase because that requires a force-push.

Copilot stopped work on behalf of Tieske due to an error September 16, 2026 20:22
Copilot AI requested a review from Tieske September 16, 2026 20:22
@Tieske Tieske changed the title Make test_iconv portable across iconv implementations that do not support utf8/utf16 aliases Make test_iconv portable across iconv implementations Sep 16, 2026
@Tieske
Tieske merged commit a94fdb1 into master Sep 16, 2026
12 checks passed
@Tieske
Tieske deleted the copilot/fix-test-iconv-failing-calls branch September 16, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

test_iconv.lua fails on termux due to missing hyphens

2 participants