Skip to content

Fix RDMA project branch merge from v2 #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yec-akamai merged 2 commits into from
Jul 8, 2026
Merged

Fix RDMA project branch merge from v2 #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b1e65
fix v2
yec-akamai Jul 7, 2026
b52e70d
udpate
yec-akamai Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions interfaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ type LinodeInstanceInterfaceCreateOptions struct {
}

type LinodeInterfaceUpdateOptions struct {
DefaultRoute *InterfaceDefaultRoute `json:"default_route,omitempty"`
Public *PublicInterfaceCreateOptions `json:"public,omitempty"`
VPC *VPCInterfaceUpdateOptions `json:"vpc,omitempty"`
DefaultRoute *InterfaceDefaultRouteUpdateOptions `json:"default_route,omitzero"`
Public *PublicInterfaceCreateOptions `json:"public,omitzero"`
VPC *VPCInterfaceUpdateOptions `json:"vpc,omitzero"`

// NOTE: RDMA VPC interfaces may not currently be available to all users.
RDMAVPC *RDMAVPCInterfaceUpdateOptions `json:"rdma_vpc,omitzero"`
Expand Down
4 changes: 2 additions & 2 deletions test/unit/rdma_vpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"testing"

"github.com/jarcoal/httpmock"
"github.com/linode/linodego"
"github.com/linode/linodego/v2"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down Expand Up @@ -294,7 +294,7 @@ func TestInstance_CreateWithLinodeInterfaces_BackwardsCompatible(t *testing.T) {
VPC: &linodego.VPCInterfaceCreateOptions{
SubnetID: 4,
IPv4: &linodego.VPCInterfaceIPv4CreateOptions{
Addresses: &[]linodego.VPCInterfaceIPv4AddressCreateOptions{
Addresses: []linodego.VPCInterfaceIPv4AddressCreateOptions{
{
Address: linodego.Pointer("10.0.0.5"),
Primary: linodego.Pointer(true),
Expand Down
2 changes: 1 addition & 1 deletion vpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type VPCCreateOptions struct {
Label string `json:"label"`
Description string `json:"description,omitzero"`
Region string `json:"region"`

// This field is omitted by the API for customers that do not have
// access to the GPUDirect RDMA functionality.
// NOTE: RDMA VPCs may not currently be available to all users.
Expand Down