Fix RDMA project branch merge from v2#1003
Merged
Merged
Conversation
yec-akamai
requested review from
ezilber-akamai and
mawilk90
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes regressions from merging linodego/v2 into the RDMA project branch by aligning interface update types and updating RDMA VPC unit tests to match the v2 module path and current option struct shapes.
Changes:
- Adjust
LinodeInterfaceUpdateOptionsto useInterfaceDefaultRouteUpdateOptionsforDefaultRoute. - Update RDMA VPC unit tests to import
github.com/linode/linodego/v2and to use the non-pointerAddressesslice shape. - Minor formatting cleanup in
vpc.go.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vpc.go | Formatting-only cleanup around VPCCreateOptions. |
| interfaces.go | Updates the interface update options type for DefaultRoute (and touches JSON tags). |
| test/unit/rdma_vpc_test.go | Fixes v2 import path and updates test data to match current Addresses field type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yec-akamai
added
the
hotfix
ezilber-akamai
approved these changes
Jul 7, 2026
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Changes look good and tests passing locally!
zliang-akamai
approved these changes
Jul 8, 2026
mawilk90
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix some issues introduced from merge linodego v2 into the rdma project branch.
✔️ How to Test