Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/sedna/service/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ def http_request(
_maxTimeout = timeout if timeout else 300
_method = "GET" if not method else method
try:
response = requests.request(method=_method, url=url, **kwargs)
response = requests.request(
method=_method, url=url, timeout=_maxTimeout, **kwargs)
if response.status_code == 200:
if no_decode:
return response
Expand Down
33 changes: 33 additions & 0 deletions lib/tests/test_service_client.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import unittest
from unittest.mock import Mock, patch

from sedna.service.client import http_request


class HTTPRequestTest(unittest.TestCase):

@patch("sedna.service.client.requests.request")
def test_forwards_explicit_timeout(self, request):
response = Mock(status_code=200)
request.return_value = response

self.assertIs(http_request(
"http://example.test", timeout=7, no_decode=True), response)

request.assert_called_once_with(
method="GET", url="http://example.test", timeout=7)

@patch("sedna.service.client.requests.request")
def test_forwards_default_timeout(self, request):
response = Mock(status_code=200)
request.return_value = response

self.assertIs(http_request(
"http://example.test", no_decode=True), response)

request.assert_called_once_with(
method="GET", url="http://example.test", timeout=300)


if __name__ == "__main__":
unittest.main()