Repository navigation
fix: propagate configured HTTP request timeout - #489
Open
blackdragoon26 wants to merge 2 commits into
Open
blackdragoon26 wants to merge 2 commits into
blackdragoon26 wants to merge 2 commits into
Conversation
Forward the existing timeout value to requests so Sedna client calls honor their configured deadline without changing retry behavior. Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
kubeedge-bot
added
kind/bug
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @blackdragoon26! It looks like this is your first PR to kubeedge/sedna 🎉 |
kubeedge-bot
added
the
size/XS
blackdragoon26
marked this pull request as ready for review
August 14, 2026 10:28
kubeedge-bot
removed
the
do-not-merge/work-in-progress
Author
|
Kindly review this PR |
kubeedge-bot
added
size/M
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/http-request-timeout
branch
from
August 24, 2026 14:12
0846721 to
eac0ef5
Compare
Author
Re-pinging for the review, thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Forwards the timeout already computed by
http_request()torequests.request(). Explicit timeouts now take effect, while the existing 300-second default and retry behavior remain unchanged.Which issue(s) this PR fixes:
Fixes #488
Validation:
Added
lib/tests/test_service_client.pywith focused cases proving that both an explicit timeout and the 300-second default are forwarded torequests.request().Result: 2 tests passed. Python compilation and
git diff --checkalso pass.