feat(mac): new configuration and installation UI 🍎 - #16304
Open
sgschantz wants to merge 44 commits into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
Bot
changed the title
This was referenced Aug 5, 2026
delete keyboard button and changed it to work with UUID instead of index
and did minor refactoring
no longer required because of changes to the way installed packages are removed
for whether or not a package's disclosure group is expanded
and style changes
Co-authored-by: Shawn Schantz <89134789+sgschantz@users.noreply.github.com>
Co-authored-by: Shawn Schantz <89134789+sgschantz@users.noreply.github.com>
feat(mac): add new configuration window 🍎
feat(mac): add views for completing installation 🍎
also fixed bug blocking removal of packages that were installed during the same session
When installed, packages keep a reference to their location on disk so that they can delete their associated files if removed. However, installation from the internet now happens via a temp directory. The directory must be updated when moved to the install directory and there can be no trace of the temp directory path anywhere when loading other data from the package. The cleanest way to accomplish this was to use computed properties for the locations of all the data like welcome.htm and the graphic image. These properties are based on the single package directory URL, and this URL is updated when the package is moved.
If the help file (welcome.htm) and readme file (readme.htm) are not listed in the options element of the kmp.json, check the file list. Read them from the package using their default filenames if they are found there.
listen to correct notifications for permission granted standardize file URLs use correct loadFileURl to load help file URL as it it is not loading over HTTP
also fixed typos, removed a few print statements
Member
|
This PR has a lot of new user interface. IMHO we need some user tests. |
mcdurdin
approved these changes
Aug 17, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
I think this LGTM; i18n needs to be done on strings throughout
Contributor
Author
Agreed, I'll add some |
Contributor
Author
Yes, I am going to go through and move everything to string resources and also add logging as separate PRs. I avoided doing this when three of us were working on the UI because it would probably create some messy merge conflicts. |
This was
linked to
issues
Aug 18, 2026
Open
added 1024 x 1024 app icon replaced Apple's installer icon with symbol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the UI for configuration and completion of installation with the final (or nearly final) design.
Note: this code still includes two windows used for debugging installation and config and these will be removed later. (Most of those related views have 'Debug' in their name.)
Fixes: #9369
Fixes: #9875
Fixes: #12572
Fixes: #13763
Build-bot: release:mac
Test-bot: skip