Repository navigation
Fail closed when av_sync cannot load a scene spec - #98
Merged
Merged
Conversation
Corrupt or invalid *.scene.yaml was skipped, so av_sync fell back to transcript nouns and could still pass. Raise on load failure and map validator exceptions to a failed check (soft on --pre-push). Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 20:22
Local ruff, pytest, and docgen benchmark are green on this branch. Co-authored-by: jmjava <jmjava@gmail.com>
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AVSyncValidator._anchors_from_scene_specsswallowedload_scene_specerrors withcontinue. A corrupt*.scene.yamlthen looked like “no spec anchors”, so_get_anchorsfell back to transcript nouns. OCR could still pass on unrelated long words while the board YAML was unreadable.story_endalready fails when a spec cannot load. A crash insidevalidate_segment_with_timingalso escaped_check_av_syncas a traceback.Change
ValueErrorinstead of being skipped._check_av_syncmaps validator exceptions topassed=False(soft on--pre-push, same as layout).Milestone:
milestones/av-sync-scene-spec.md. Also markslayout-check-errorsas shipped (#97).Out of scope
av_syncstays soft onvalidate --pre-push.validation.av_sync.anchor_keywordstype gating is separate.Gates
ruff check src/ tests/pytest tests/docgen benchmark(no clock change; no--update-baseline)