Repository navigation
Fail closed when av_sync.anchor_keywords is not a mapping - #101
Merged
Merged
Conversation
A YAML list or string for anchor_keywords made .get(seg_id) traceback (or, after #98, a soft av_sync miss). Require a mapping of segment ids to lists of {keyword, …} rows at Config.from_yaml. Co-authored-by: jmjava <jmjava@gmail.com>
Local ruff, pytest, and docgen benchmark are green on this branch. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AVSyncValidator._get_anchorsdoessync_cfg.get("anchor_keywords", {}).get(seg_id, [])thena["keyword"].A YAML list or string for
anchor_keywordsraisedAttributeError(or, after #98, a softav_syncfailure). A per-segment string was iterated as characters.visual_typesis already a typed list; nestedanchor_keywordswas not.Change
validation.av_sync.anchor_keywordsmust be a mapping of segment-id strings to lists of mappings with a stringkeyword.Milestone:
milestones/av-sync-anchor-keywords.md. Also markswizard-prompt-stringsas shipped (#100).Out of scope
expected_atnumeric type is not gated.Gates
ruff check src/ tests/pytest tests/docgen benchmark(no clock change; no--update-baseline)