Repository navigation
Fail closed when Manim layout check crashes - #97
Merged
Merged
Conversation
Unexpected LayoutValidator exceptions were returned as passed=True skips, so validate --pre-push still printed All checks passed. Treat those errors like stream/drift failures (soft on pre-push). Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Validator._check_layoutskipped unexpected exceptions as success (passed=True,"Layout check error (skipped): …"). Stream and drift checks already fail on the same kind of crash. Layout is a--pre-pushsoft check, so a TypeError/KeyError fromLayoutValidatorstill printed All checks passed.Tesseract-not-installed remains a skip (same as OCR).
Change
_check_layoutreturnpassed=False.LayoutReport.Milestone:
milestones/layout-check-errors.md. Also marksmanim-unsafe-unicodeas shipped (#96).Out of scope
validate --pre-push.av_syncswallowing unreadable*.scene.yamlis a separate hole.Gates
ruff check src/ tests/pytest tests/docgen benchmark(no clock change; no--update-baseline)