Repository navigation
Fail closed when manim.unsafe_unicode is not a YAML list - #96
Merged
Merged
Conversation
The property already raised on a scalar, but only when validate or scene-spec-generate read it. Evaluate it in Config.from_yaml and require string list items, matching manim.scenes. Co-authored-by: jmjava <jmjava@gmail.com>
Local ruff, pytest, and docgen benchmark are green on this branch. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
manim.unsafe_unicodeas a YAML string already raisedConfigErrorwhen the property was read (validate / scene-spec-generate).Config.from_yamldid not touch it, soyaml-generate,tts, and other commands could load a bad file.Change
Evaluate
manim_unsafe_unicodeduringConfig.from_yaml(same asmanim.scenes). Usestring_list_blockso items must be YAML strings. Missing/null still uses the built-in Pango fallback list;[]still disables unicode lint.Milestone:
milestones/manim-unsafe-unicode.mdOut of scope