Conversation
Greptile SummaryThis PR upgrades the newton physics library by updating the pinned git commit hash from its previous value to The newton commit hash is applied consistently across all four references (newton, rerun, and viser extras in Confidence Score: 5/5Safe to merge — the newton git hash is updated consistently across all dependency references and golden images are refreshed accordingly. Changes are minimal and internally consistent: all four newton git-ref strings point to the same new commit, and updated golden images are the expected side-effect of a rendering-library bump. No logic changes, no new regressions introduced. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[isaaclab_newton/setup.py] -->|extras_require all| N[newton @ git+...@a27277ed]
B[isaaclab_visualizers/setup.py] -->|extras_require newton| N
B -->|extras_require rerun| N
B -->|extras_require viser| N
N -->|fetched from| G[github.com/newton-physics/newton]
C[golden_images/dexsuite_kuka/] -->|updated to match| N
Reviews (2): Last reviewed commit: "another version of newton" | Re-trigger Greptile |
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR upgrades the Newton physics library dependency from commit 2684d75 to a27277e (88 commits ahead). The updated golden test images reflect visual changes from the new Newton version. The change is straightforward — a dependency pin update with corresponding test baseline refresh.
Architecture Impact
No cross-module impact beyond the dependency update. All four locations referencing the Newton git URL (isaaclab_newton/setup.py and three extras in isaaclab_visualizers/setup.py) are consistently updated to the same commit SHA.
Implementation Verdict
Minor fixes needed — The implementation is correct, but the PR is missing required documentation updates per project conventions.
Test Coverage
The golden image updates serve as visual regression tests for the Newton renderer integration. No new code paths are introduced, so no additional unit tests are required. The updated baselines correctly reflect expected rendering changes from the Newton upgrade.
CI Status
Most checks passing ✅. Docker image builds are pending but not blocking. Pre-commit, license, docs, and installation tests all pass.
Findings
🟡 Warning: Missing CHANGELOG entry
Per the PR checklist and project conventions, dependency version upgrades should be documented in the CHANGELOG. The source/isaaclab_newton/docs/CHANGELOG.rst should include an entry noting the Newton dependency upgrade from 2684d75 to a27277e. This is a significant upgrade (88 commits) that may affect simulation behavior.
Suggested addition to CHANGELOG.rst under a new version bump or current unreleased section:
Changed
^^^^^^^
* Upgraded Newton physics library dependency from ``2684d75`` to ``a27277e``
(88 commits). Includes collision improvements, contact quality fixes,
hydroelastic contact optimization, and memory usage fixes in CollisionPipeline.
See `Newton changelog <https://github.com/newton-physics/newton>`_ for details.🟡 Warning: PR description is template boilerplate
The PR description still contains the default template text ("Please include a summary of the change..."). A clear description explaining the Newton upgrade and any notable changes from the 88 upstream commits would help reviewers and future archaeology.
🔵 Improvement: Consider bumping extension version
If this Newton upgrade introduces any user-visible behavior changes (which is likely given 88 commits including collision and contact improvements), consider bumping the isaaclab_newton version in config/extension.toml from 0.5.17 to 0.5.18. The CHANGELOG already has entries up to 0.5.17.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there