Skip to content

Upgrade newton#5339

Draft
huidongc wants to merge 2 commits intoisaac-sim:developfrom
huidongc:upgrade-newton
Draft

Upgrade newton#5339
huidongc wants to merge 2 commits intoisaac-sim:developfrom
huidongc:upgrade-newton

Conversation

@huidongc
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Apr 20, 2026
@huidongc huidongc marked this pull request as draft April 20, 2026 23:35
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 20, 2026

Greptile Summary

This PR upgrades the newton physics library by updating the pinned git commit hash from its previous value to a27277ed49d6f307b8a1e4c394be7e1d14965a62 across both isaaclab_newton/setup.py and isaaclab_visualizers/setup.py, and updates four golden test images in dexsuite_kuka/ to reflect the new rendering output.

The newton commit hash is applied consistently across all four references (newton, rerun, and viser extras in isaaclab_visualizers, and the all extra in isaaclab_newton).

Confidence Score: 5/5

Safe to merge — the newton git hash is updated consistently across all dependency references and golden images are refreshed accordingly.

Changes are minimal and internally consistent: all four newton git-ref strings point to the same new commit, and updated golden images are the expected side-effect of a rendering-library bump. No logic changes, no new regressions introduced.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_newton/setup.py Newton git dependency updated to new commit hash a27277ed; hash is consistent with isaaclab_visualizers/setup.py.
source/isaaclab_visualizers/setup.py Newton git dependency updated to same new commit hash across all three extras (newton, rerun, viser).
source/isaaclab_tasks/test/golden_images/dexsuite_kuka/newton-newton_renderer-rgb.png Golden image updated to match new newton rendering output.
source/isaaclab_tasks/test/golden_images/dexsuite_kuka/physx-newton_renderer-rgb.png Golden image updated to match new newton rendering output.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[isaaclab_newton/setup.py] -->|extras_require all| N[newton @ git+...@a27277ed]
    B[isaaclab_visualizers/setup.py] -->|extras_require newton| N
    B -->|extras_require rerun| N
    B -->|extras_require viser| N
    N -->|fetched from| G[github.com/newton-physics/newton]
    C[golden_images/dexsuite_kuka/] -->|updated to match| N
Loading

Reviews (2): Last reviewed commit: "another version of newton" | Re-trigger Greptile

Comment thread source/isaaclab_newton/setup.py Outdated
Copy link
Copy Markdown

@isaaclab-review-bot isaaclab-review-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Isaac Lab Review Bot

Summary

This PR upgrades the Newton physics library dependency from commit 2684d75 to a27277e (88 commits ahead). The updated golden test images reflect visual changes from the new Newton version. The change is straightforward — a dependency pin update with corresponding test baseline refresh.

Architecture Impact

No cross-module impact beyond the dependency update. All four locations referencing the Newton git URL (isaaclab_newton/setup.py and three extras in isaaclab_visualizers/setup.py) are consistently updated to the same commit SHA.

Implementation Verdict

Minor fixes needed — The implementation is correct, but the PR is missing required documentation updates per project conventions.

Test Coverage

The golden image updates serve as visual regression tests for the Newton renderer integration. No new code paths are introduced, so no additional unit tests are required. The updated baselines correctly reflect expected rendering changes from the Newton upgrade.

CI Status

Most checks passing ✅. Docker image builds are pending but not blocking. Pre-commit, license, docs, and installation tests all pass.

Findings

🟡 Warning: Missing CHANGELOG entry
Per the PR checklist and project conventions, dependency version upgrades should be documented in the CHANGELOG. The source/isaaclab_newton/docs/CHANGELOG.rst should include an entry noting the Newton dependency upgrade from 2684d75 to a27277e. This is a significant upgrade (88 commits) that may affect simulation behavior.

Suggested addition to CHANGELOG.rst under a new version bump or current unreleased section:

Changed
^^^^^^^

* Upgraded Newton physics library dependency from ``2684d75`` to ``a27277e``
  (88 commits). Includes collision improvements, contact quality fixes,
  hydroelastic contact optimization, and memory usage fixes in CollisionPipeline.
  See `Newton changelog <https://github.com/newton-physics/newton>`_ for details.

🟡 Warning: PR description is template boilerplate
The PR description still contains the default template text ("Please include a summary of the change..."). A clear description explaining the Newton upgrade and any notable changes from the 88 upstream commits would help reviewers and future archaeology.

🔵 Improvement: Consider bumping extension version
If this Newton upgrade introduces any user-visible behavior changes (which is likely given 88 commits including collision and contact improvements), consider bumping the isaaclab_newton version in config/extension.toml from 0.5.17 to 0.5.18. The CHANGELOG already has entries up to 0.5.17.

@huidongc huidongc marked this pull request as ready for review April 21, 2026 05:23
@huidongc huidongc marked this pull request as draft April 21, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant