Skip to content

Three little changes #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thehrh merged 9 commits into from
Dec 17, 2025
Merged

Three little changes #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bd35bd9
Allow relative pid improvement and remove pid stage
JanWeldert Oct 23, 2025
fe68d4d
Remove pid stage from globals
JanWeldert Oct 27, 2025
be5620c
Merge branch 'icecube:master' into master
JanWeldert Dec 16, 2025
aed4234
Clip number of events after Gaussian smearing
JanWeldert Dec 16, 2025
ffc6e72
Merge branch 'master' of https://github.com/JanWeldert/pisa
JanWeldert Dec 16, 2025
986089e
Do not create linked container if none of the containers exist
JanWeldert Dec 16, 2025
ca003e3
Merge branch 'icecube:master' into master
JanWeldert Dec 17, 2025
4fd7f0c
Make adaptive KDE an option
JanWeldert Dec 17, 2025
ae0d31d
Merge branch 'master' of https://github.com/JanWeldert/pisa
JanWeldert Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pisa/core/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,12 @@ def link_containers(self, key, names):
% (set(names) - set(self.names))
)
containers = [self.__getitem__(name) for name in link_names]
logging.trace('Linking containers %s into %s'%(link_names, key))
new_container = VirtualContainer(key, containers)
self.linked_containers.append(new_container)

if len(containers) > 0:
logging.trace('Linking containers %s into %s'%(link_names, key))
new_container = VirtualContainer(key, containers)
self.linked_containers.append(new_container)
else:
logging.warning("None of the containers exist, skipping %s"%(key))

def unlink_containers(self):
"""Unlink all container"""
Expand Down
1 change: 1 addition & 0 deletions pisa/core/map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,7 @@ def fluctuate(self, method, random_state=None, jumpahead=None):
loc=orig_hist[valid_mask], scale=sigma[valid_mask],
random_state=random_state
)
gauss = np.clip(gauss, a_min=0, a_max=None)

hist_vals = np.empty_like(orig_hist, dtype=np.float64)
hist_vals[valid_mask] = poisson.rvs(
Expand Down
3 changes: 3 additions & 0 deletions pisa/stages/utils/kde.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def __init__(
coszen_name="reco_coszen",
oversample=10,
coszen_reflection=0.25,
adaptive=True,
alpha=0.1,
stack_pid=True,
stash_hists=False,
Expand All @@ -70,6 +71,7 @@ def __init__(
self.oversample = int(oversample)
self.coszen_reflection = float(coszen_reflection)
self.alpha = float(alpha)
self.adaptive = adaptive
self.stack_pid = stack_pid
self.stash_hists = stash_hists
self.stash_valid = False
Expand Down Expand Up @@ -185,6 +187,7 @@ def apply_function(self):
bw_method=self.bw_method,
coszen_name=self.coszen_name,
coszen_reflection=self.coszen_reflection,
adaptive=self.adaptive,
alpha=self.alpha,
oversample=self.oversample,
use_cuda=False,
Expand Down