Skip to content

Three little changes - #891

Merged
thehrh merged 9 commits into
icecube:masterfrom
JanWeldert:master
Dec 17, 2025
Merged

thehrh merged 9 commits into
icecube:masterfrom
JanWeldert:master

Conversation

@JanWeldert

Copy link
Copy Markdown
Collaborator
  1. Clip number of events to 0 when we do Gaussian fluctuations.
  2. Do not create a linked container if none of the containers that should be linked exist.
  3. Make it an option to use adaptive KDEs in the KDE stage (default). So far, using adaptive KDEs was forced on the user.

Only three of the nine commit here are important. Looks like I have to clean up my repo again :\

@thehrh

thehrh commented Dec 17, 2025 •

Copy link
Copy Markdown
Collaborator

The kde service is lacking documentation of its adaptive init arg, but I'm going to let you off the hook since several of the others aren't documented either.

Since we don't have associated issues, it would be nice if you could edit your original comment to also include a motivation for each change where it isn't trivially obvious, so for 1. + 2. I'd say.

@thehrh
thehrh merged commit 1cc768c into icecube:master Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants