Skip to content

fix: omit empty ingressClassName (CLI-64568) #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imsoumik03 merged 1 commit into from
Aug 30, 2026
Merged

fix: omit empty ingressClassName (CLI-64568) #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## [1.9.8] - 2026-08-29

### Fixed
- Omit `spec.ingressClassName` when `global.ingress.className` is empty.

## [1.9.7] - 2026-08-24

### Changed
Expand Down
6 changes: 3 additions & 3 deletions ci/test-chart/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: harness-common
repository: file://../../src/common
version: 1.9.7
digest: sha256:c747685f90f25fc4d6b27ae6c72d5339d977052f40a6201f5c1050d33b1e8285
generated: "2026-08-24T15:19:06.633153+05:30"
version: 1.9.8
digest: sha256:7025eac7a26f1c32b6ec9c4f80ad643f09a5c50476a230aeaacaa7e2dd1e5ded
generated: "2026-08-29T23:10:09.543088+05:30"
2 changes: 1 addition & 1 deletion src/common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: library
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.9.7
version: 1.9.8


# This is the version number of the application being deployed. This version number should be
Expand Down
2 changes: 2 additions & 0 deletions src/common/templates/_ingress.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ metadata:
{{- end }}
{{- end }}
spec:
{{- if $.Values.global.ingress.className }}
ingressClassName: {{ $.Values.global.ingress.className | quote }}
{{- end }}
rules:
{{- if $.Values.global.ingress.disableHostInIngress }}
- http:
Expand Down