Skip to content

fix: omit empty ingressClassName (CLI-64568) - #244

Merged
imsoumik03 merged 1 commit into
harness:mainfrom
Revanth-Badveli:fix/CLI-64568-ingress-class-name
Aug 30, 2026
Merged

fix: omit empty ingressClassName (CLI-64568)#244
imsoumik03 merged 1 commit into
harness:mainfrom
Revanth-Badveli:fix/CLI-64568-ingress-class-name

Conversation

@Revanth-Badveli

@Revanth-Badveli Revanth-Badveli commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Omit spec.ingressClassName when global.ingress.className is empty.
  • Prevent an empty field from overriding the legacy ingress-class annotation and breaking controller selection.

Test plan

  • helm lint src/common
  • HELM_REPOSITORY_CONFIG=/dev/null ./ci/run-tests.sh

Co-authored-by: Cursor <cursoragent@cursor.com>
@imsoumik03
imsoumik03 merged commit 63d05e1 into harness:main Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants