Repository navigation
Conversation
default behavior remains but if there is a postgres existing secret use that along with the specified userPasswordKey
This was referenced Aug 25, 2026
Collaborator
|
Thanks! Merged into #216, which consolidates this with #191 and #200 into a 4.2.0 release. Your commit is carried over with you credited via One thing I added on top: the patch referenced This will ship in the next chart version (4.2.0). Closing in favour of #216. |
ranyhb
added a commit
that referenced
this pull request
Aug 26, 2026
* fix: emit SQLALCHEMY_ENABLE_POOL_PRE_PING values.yaml has documented redash.sqlAlchemyEnablePoolPrePing with a default of "true" since it was added, but the shared env helper never emitted the variable, so setting it did nothing. Upstream: #200 Co-authored-by: brianrudolf <brianrudolf@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: honor postgresql.auth.existingSecret for the database password REDASH_DATABASE_PASSWORD was hardcoded to the `password` key of the chart-managed `<release>-postgresql` secret. A release pointing the bundled PostgreSQL at an existing secret left Redash referencing a secret that does not exist. Adds the accompanying postgresql.auth.existingSecret and postgresql.auth.secretKeys.userPasswordKey values, which the upstream PR referenced but never declared, so the key does not resolve empty when only existingSecret is set. Default renders are unchanged. Upstream: #195 Co-authored-by: seslly <seslly@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: add topologySpreadConstraints to all workloads Exposes topologySpreadConstraints for the server, workers, scheduler and migrations job, alongside the existing nodeSelector/affinity/ tolerations settings. Reimplemented rather than applied: the upstream patch referenced `.Values.$workerConfig.topologySpreadConstraints` in the worker template, which is not valid template syntax and made the whole chart fail to render with `bad character U+0024 '$'`. Workers read the merged $workerConfig, so per-worker overrides of the shared worker.topologySpreadConstraints default work. The upstream patch also used `indent 8` where the surrounding blocks use `nindent 8`, which would have emitted malformed YAML, and declared the value as `{}` though the field is a list. Also applied to the Knative Service template, which the upstream PR predates. Note that Knative gates this PodSpec field, so it needs the corresponding config-features flag enabled. Upstream: #191 Co-authored-by: Mason0920 <Mason0920@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: release 4.2.0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: add topologySpreadConstraints to Knative pod settings and quote secret names --------- Co-authored-by: brianrudolf <brianrudolf@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: seslly <seslly@users.noreply.github.com> Co-authored-by: Mason0920 <Mason0920@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default behavior remains but if there is a postgres existing secret use that along with the specified userPasswordKey