Repository navigation
Conversation
|
Thanks for this — the feature is a good addition and it's now in #216, which consolidates it with #195 and #200 into a 4.2.0 release. You're credited via I had to reimplement the templates rather than apply them, because the patch as written stops the chart rendering at all:
With that fixed, per-worker overrides work as you'd expect — This will ship in the next chart version (4.2.0). Closing in favour of #216. |
* fix: emit SQLALCHEMY_ENABLE_POOL_PRE_PING values.yaml has documented redash.sqlAlchemyEnablePoolPrePing with a default of "true" since it was added, but the shared env helper never emitted the variable, so setting it did nothing. Upstream: #200 Co-authored-by: brianrudolf <brianrudolf@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: honor postgresql.auth.existingSecret for the database password REDASH_DATABASE_PASSWORD was hardcoded to the `password` key of the chart-managed `<release>-postgresql` secret. A release pointing the bundled PostgreSQL at an existing secret left Redash referencing a secret that does not exist. Adds the accompanying postgresql.auth.existingSecret and postgresql.auth.secretKeys.userPasswordKey values, which the upstream PR referenced but never declared, so the key does not resolve empty when only existingSecret is set. Default renders are unchanged. Upstream: #195 Co-authored-by: seslly <seslly@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: add topologySpreadConstraints to all workloads Exposes topologySpreadConstraints for the server, workers, scheduler and migrations job, alongside the existing nodeSelector/affinity/ tolerations settings. Reimplemented rather than applied: the upstream patch referenced `.Values.$workerConfig.topologySpreadConstraints` in the worker template, which is not valid template syntax and made the whole chart fail to render with `bad character U+0024 '$'`. Workers read the merged $workerConfig, so per-worker overrides of the shared worker.topologySpreadConstraints default work. The upstream patch also used `indent 8` where the surrounding blocks use `nindent 8`, which would have emitted malformed YAML, and declared the value as `{}` though the field is a list. Also applied to the Knative Service template, which the upstream PR predates. Note that Knative gates this PodSpec field, so it needs the corresponding config-features flag enabled. Upstream: #191 Co-authored-by: Mason0920 <Mason0920@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: release 4.2.0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: add topologySpreadConstraints to Knative pod settings and quote secret names --------- Co-authored-by: brianrudolf <brianrudolf@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: seslly <seslly@users.noreply.github.com> Co-authored-by: Mason0920 <Mason0920@users.noreply.github.com>
Hi,
I need topologySpreadConstraints, so I create PR on this repo
about topologySpreadConstraints, you can visit here
I would be useful for other users.