Skip to content

perf(ci): consolidate resource generation and untagged vet #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityathebe merged 1 commit into from
Sep 9, 2026
Merged

perf(ci): consolidate resource generation and untagged vet #2387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ jobs:

- name: Generate resources
run: make resources
- name: Verify generated CRDs are committed
- name: Verify generated resources and formatting are committed
run: |
if [ -n "$(git status --porcelain -- chart/crds)" ]; then
git status --short -- chart/crds
echo "::error::Generated CRDs are out of date. Run 'make manifests' and commit the changes."
if [ -n "$(git status --porcelain -- '*.go' chart/crds config/schemas)" ]; then
git status --short -- '*.go' chart/crds config/schemas
echo "::error::Generated resources or Go formatting are out of date. Run 'make resources' and commit the changes."
exit 1
fi
- name: Vet
run: make vet
- name: golangci-lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
8 changes: 5 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ name: Test
permissions:
contents: read

# Lint verifies generation, formatting and untagged vet. These suites use the
# committed generated files so each variant need not repeat that preparation.
jobs:
test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -39,7 +41,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
run: make envtest
- name: Test
run: make test
run: make gotest

test-playwright:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -160,7 +162,7 @@ jobs:
postgrest
GITHUB_TOKEN: ${{ github.token }}
- name: Test
run: make test-prod
run: make envtest gotest-prod

clickhouse-e2e:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -212,7 +214,7 @@ jobs:
- name: Setup
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: make manifests generate fmt vet envtest
run: make envtest
- name: Test
run: make test-fast

Expand Down
Loading