perf(ci): consolidate resource generation and untagged vet

[adityathebe]

Full, production and slim CI jobs repeated generation, formatting and the same untagged vet pass; slim preparation alone took 9m45s in the sampled run.

• Keep generation and explicit full vet in the existing Lint job; verify committed Go formatting, generated Go, JSON schemas and CRDs.
• Use existing suite leaf targets with envtest provisioning retained; local Makefile entry points remain unchanged.
• Keep Lint required when merging: committed generated output is now the shared contract, without adding an artifact dependency to every job.

[coderabbitai]

Warning

Review limit reached

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 047dffe6-55c1-41ec-8d95-4b5d001a940c

📥 Commits

Reviewing files that changed from the base of the PR and between 917781f and 48dc73b.

📒 Files selected for processing (2)

• .github/workflows/lint.yml
• .github/workflows/test.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Benchstat

Base: 917781fadfc7ccb16973cab22d725b06732e4a4b
Head: 48dc73b72df5831219fb5d98e83a7601eb2f5642

✅ 1 improvement(s)

Benchmark	Base	Head	Change	p-value
LocationFilter/largeEnv-4	39.77µ	38.18µ	-3.99%	0.009

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/config-db/bench
cpu: INTEL(R) XEON(R) PLATINUM 8573C
                                         │ bench-base.txt │           bench-head.txt           │
                                         │     sec/op     │    sec/op     vs base              │
LocationFilter/smallEnv-4                    17.88µ ± 14%   17.62µ ± 17%       ~ (p=0.589 n=6)
LocationFilter/largeEnv-4                    39.77µ ±  4%   38.18µ ±  2%  -3.99% (p=0.009 n=6)
RunTemplateBool/smallEnv-4                   9.319µ ±  2%   9.232µ ±  3%       ~ (p=0.290 n=6)
RunTemplateBool/largeEnv-4                   17.47µ ±  4%   16.97µ ±  4%       ~ (p=0.180 n=6)
BenchSaveResultsSeed/N=1000-4                 2.651 ±  8%    2.595 ±  9%       ~ (p=0.310 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      2.490 ±  3%    2.554 ±  4%       ~ (p=0.093 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        5.442 ±  5%    5.668 ±  2%       ~ (p=0.093 n=6)
geomean                                      3.288m         3.265m        -0.70%

                                         │ bench-base.txt │            bench-head.txt            │
                                         │      B/op      │     B/op      vs base                │
LocationFilter/smallEnv-4                    15.76Ki ± 0%   15.76Ki ± 0%       ~ (p=1.000 n=6) ¹
LocationFilter/largeEnv-4                    21.17Ki ± 0%   21.17Ki ± 0%  +0.00% (p=0.002 n=6)
RunTemplateBool/smallEnv-4                   9.149Ki ± 0%   9.149Ki ± 0%       ~ (p=1.000 n=6) ¹
RunTemplateBool/largeEnv-4                   10.95Ki ± 0%   10.95Ki ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsSeed/N=1000-4                1.295Gi ± 0%   1.295Gi ± 0%       ~ (p=1.000 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     32.03Mi ± 0%   32.02Mi ± 0%       ~ (p=0.485 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       796.4Mi ± 1%   795.7Mi ± 1%       ~ (p=0.589 n=6)
geomean                                      1.004Mi        1.004Mi       -0.02%
¹ all samples are equal

                                         │ bench-base.txt │            bench-head.txt            │
                                         │   allocs/op    │  allocs/op    vs base                │
LocationFilter/smallEnv-4                     300.0 ±  0%    300.0 ±  0%       ~ (p=1.000 n=6) ¹
LocationFilter/largeEnv-4                     544.0 ±  0%    544.0 ±  0%       ~ (p=1.000 n=6) ¹
RunTemplateBool/smallEnv-4                    238.0 ±  0%    238.0 ±  0%       ~ (p=1.000 n=6) ¹
RunTemplateBool/largeEnv-4                    319.0 ±  0%    319.0 ±  0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsSeed/N=1000-4                741.7k ±  0%   741.7k ±  0%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     405.9k ±  0%   405.9k ±  0%       ~ (p=0.589 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       992.1k ± 12%   992.0k ± 12%       ~ (p=1.000 n=6)
geomean                                      8.676k         8.676k        -0.00%
¹ all samples are equal

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      MB/s      │    MB/s     vs base                │
BenchSaveResultsSeed/N=1000-4                0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateUnchanged/N=1000-4     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateChanged/N=1000-4       0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                 ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

[github-actions]

Gavel summary

Source	Pass	Fail	Skip	Duration
api	11	0	0	2ms
aws	98	0	0	25ms
azure	43	0	0	1ms
changes	30	0	0	5.7s
cmd	5	0	0	296.429µs
db	97	0	0	19.2s
devops	208	0	0	8ms
exec	12	0	0	2m4s
extract	50	0	0	45ms
file	9	0	0	260.594µs
gcp	90	0	0	3ms
github	78	0	3	17ms
github.com/flanksource/config-db/api/v1	11	0	0	-
github.com/flanksource/config-db/cmd	5	0	0	5.4s
github.com/flanksource/config-db/cmd/scrapeui	2	0	0	-
github.com/flanksource/config-db/db	22	0	0	-
github.com/flanksource/config-db/scrapers/aws	9	0	0	-
github.com/flanksource/config-db/scrapers/clickhouse	22	0	0	-
github.com/flanksource/config-db/scrapers/gcp	22	0	0	-
github.com/flanksource/config-db/scrapers/github	16	0	0	-
github.com/flanksource/config-db/scrapers/postgres	2	0	0	-
github.com/flanksource/config-db/scrapers/processors	34	0	0	50ms
github.com/flanksource/config-db/tests/clickhouse_e2e	0	0	1	-
github.com/flanksource/config-db/utils/kube	9	0	0	-
http	28	0	0	18ms
jobs	28	0	0	2m17s
kubernetes	39	0	0	1ms
playwright	9	0	0	1ms
scrapers	168	0	0	29.1s
terraform	1	0	0	3ms
tests	2	0	2	3.8s
utils	12	0	0	447.41µs
v1	149	0	0	8ms

Totals: 1321 passed · 0 failed · 6 skipped · 5m24s

View full results