Sync: wire device_info writing into the login flow for the unified device list - #9415
Draft
Conversation
This was referenced Aug 6, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/sync_unified_devices_wire_into_login_and_signup_flows
branch
from
August 6, 2026 13:56
dbafcb7 to
5f5a3c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1216792641477210?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Adds LoginDeviceInfoWriter, invoked fire-and-forget after a successful native (ddg) login. It brings the signed-in device into the unified device list world.
Login is the point where a device that just authenticated should publish its device_info and, if needed, make the account key readable by its own credential.
Behaviour / safety
• Gated on SyncFeature.canWriteUnifiedDeviceList(), which is still off by default
• Best-effort: the legacy name/type written by the login itself is the must-succeed part; nothing here can fail or block login
Steps to test this PR
Creating account
internalvariantcanUseV2ConnectFlow- should be enabled already, just checkcanWriteUnifiedDeviceListleave it disabled.canReadUnifiedDeviceListmake this enabledSync Dev Settingsand tapCreate account. Copy the recovery code by tapping on it as you'll need it laterFetch & decrypt devicesand verifyno device_infoSign out / sign in
canWriteUnifiedDeviceListReset migration marker(just in case a migration ran)