Skip to content

Remove gzip exclusion from /sync/devices endpoint now that backend supports it - #9405

Merged
CDRussell merged 1 commit into
developfrom
feature/craig/sync_unified_devices_gzip_support_devices_endpoint
Aug 6, 2026
Merged

Remove gzip exclusion from /sync/devices endpoint now that backend supports it#9405
CDRussell merged 1 commit into
developfrom
feature/craig/sync_unified_devices_gzip_support_devices_endpoint

Conversation

@CDRussell

@CDRussell CDRussell commented Aug 5, 2026

Copy link
Copy Markdown
Member

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1217193238272991?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

The backend now accepts gzipped PATCH bodies on /sync/devices. When we first integrated with this endpoint gzip wasn't supported, so SyncGzipInterceptor explicitly skipped compression for it. This removes that exclusion so devices PATCH requests are compressed like every other sync PATCH.

Steps to test this PR

  • QA optional

Note

Medium Risk
Changes how device PATCH payloads are sent to the sync API; compression failures still fall back to the uncompressed request via existing error handling.

Overview
SyncGzipInterceptor no longer skips gzip for PATCH requests to /sync/devices. Those calls now follow the same rule as other sync PATCH traffic when gzipPatchRequests is enabled.

The workaround for backend invalid_json on gzipped device PATCH bodies is removed, along with the isDevicesEndpoint check and related comment.

Reviewed by Cursor Bugbot for commit 40717bc. Configure here.

CDRussell commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@CDRussell
CDRussell force-pushed the feature/craig/sync_unified_devices_update_device_list_ui_consume_deviceinfo branch from 48da81b to f8bd813 Compare August 6, 2026 14:44
@CDRussell
CDRussell force-pushed the feature/craig/sync_unified_devices_gzip_support_devices_endpoint branch from 40717bc to 6be088e Compare August 6, 2026 14:44
@CDRussell
CDRussell changed the base branch from feature/craig/sync_unified_devices_update_device_list_ui_consume_deviceinfo to graphite-base/9405 August 6, 2026 14:58
@CDRussell
CDRussell force-pushed the feature/craig/sync_unified_devices_gzip_support_devices_endpoint branch from 6be088e to 0fcba08 Compare August 6, 2026 14:58
@CDRussell
CDRussell force-pushed the graphite-base/9405 branch from f8bd813 to 5ed6d5c Compare August 6, 2026 14:58
@graphite-app
graphite-app Bot changed the base branch from graphite-base/9405 to develop August 6, 2026 14:59
@CDRussell
CDRussell force-pushed the feature/craig/sync_unified_devices_gzip_support_devices_endpoint branch from 0fcba08 to 69698ca Compare August 6, 2026 14:59
@CDRussell
CDRussell merged commit 088b6f8 into develop Aug 6, 2026
14 checks passed

Copy link
Copy Markdown
Member Author

Merge activity

@CDRussell
CDRussell deleted the feature/craig/sync_unified_devices_gzip_support_devices_endpoint branch August 6, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants