Skip to content

fix: msvc raw strings in checks; build win in CI #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfleis merged 2 commits into from
Oct 16, 2026
Merged

fix: msvc raw strings in checks; build win in CI #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02c99e
fix: let the C++ unit tests compile with MSVC
benfleis Oct 16, 2026
e215ba7
ci: build windows_amd64 again
benfleis Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
extension_name: &ext_name unity_catalog
ci_tools_version: &ci_tools_ref main
runners: ${{ needs.prepare.outputs.runners }}
exclude_archs: wasm_mvp;wasm_eh;wasm_threads;windows_amd64_mingw;windows_amd64;linux_arm64;linux_amd64_musl
exclude_archs: wasm_mvp;wasm_eh;wasm_threads;windows_amd64_mingw;linux_arm64;linux_amd64_musl
enable_rust: true
rust_logs: true
use_merged_vcpkg_manifest: 1
Expand All @@ -47,7 +47,7 @@ jobs:
with:
extension_name: *ext_name
ci_tools_version: *ci_tools_ref
exclude_archs: wasm_mvp;wasm_eh;wasm_threads;windows_amd64_mingw;windows_amd64;linux_arm64;linux_amd64_musl
exclude_archs: wasm_mvp;wasm_eh;wasm_threads;windows_amd64_mingw;linux_arm64;linux_amd64_musl
deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
reduced_ci_mode: ${{ github.event_name == 'pull_request' && 'enabled' || 'disabled'}}

Expand Down
10 changes: 5 additions & 5 deletions test/functions/test_uc_irc_expression.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ TEST_CASE("uc irc: value formatting", "[uc][irc]") {

CHECK(One(Cmp(ExpressionType::COMPARE_EQUAL, Col("name", LogicalType::VARCHAR), Const(Value("bob")))) ==
R"({"type":"eq","term":"name","value":"bob"})");
// String escaping.
CHECK(One(Cmp(ExpressionType::COMPARE_EQUAL, Col("name", LogicalType::VARCHAR), Const(Value("a\"b")))) ==
R"({"type":"eq","term":"name","value":"a\"b"})");
// String escaping. MSVC misreads a raw string holding \" inside a macro argument, so it stays outside CHECK.
auto escaped = R"({"type":"eq","term":"name","value":"a\"b"})";
CHECK(One(Cmp(ExpressionType::COMPARE_EQUAL, Col("name", LogicalType::VARCHAR), Const(Value("a\"b")))) == escaped);
}

TEST_CASE("uc irc: non-finite double drops the term", "[uc][irc]") {
Expand All @@ -100,8 +100,8 @@ TEST_CASE("uc irc: non-finite double drops the term", "[uc][irc]") {
TEST_CASE("uc irc: a column name needing escapes is quoted", "[uc][irc]") {
// The term was concatenated in raw while values went through the escaper, so a quote in a
// column name produced a request body that is not valid JSON at all.
CHECK(One(Cmp(ExpressionType::COMPARE_EQUAL, Col(R"(we"ird)"), Const(Value::INTEGER(1)))) ==
R"({"type":"eq","term":"we\"ird","value":1})");
auto quoted = R"({"type":"eq","term":"we\"ird","value":1})";
CHECK(One(Cmp(ExpressionType::COMPARE_EQUAL, Col(R"(we"ird)"), Const(Value::INTEGER(1)))) == quoted);
}

TEST_CASE("uc irc: is-null / not-null", "[uc][irc]") {
Expand Down
Loading