Repository navigation
fix: msvc raw strings in checks; build win in CI - #154
Merged
Merged
Conversation
The unit test runner is now part of the default build, so DuckDB's Windows CI compiles it. MSVC misreads a raw string literal that holds `\"` when it sits inside a macro argument, and fails with "illegal escape sequence". The two expected strings that hold one now sit outside the CHECK.
UC's own CI is then the first to compile with MSVC, as delta's and azure's are, instead of DuckDB's Windows build finding the break after a pin bump.
benfleis
changed the title
benfleis
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: let the C++ unit tests compile with MSVC; build win in CI
MSVC misreads a raw string literal that holds
\"when it sits inside a macro argument, and fails with"illegal escape sequence". The two expected strings that hold one now sit outside the CHECK macro.