Repository navigation
Unit 5: Maintained WebView samples and cross-host integration matrix - #665
mattleibow wants to merge 1 commit into
Conversation
Expert Code Review — PR #665Methodology: 2 independent reviewers (1 failed — reduced coverage, no tiebreaker) with adversarial consensus. Result: 0 findings achieved consensus; no inline comments were posted. 3 findings were raised by an individual reviewer but none achieved the required 2/2 consensus. Discarded findings:
CI status: 13 checks succeeded and 3 were still in progress at review time; no failures were reported. Test coverage: The PR adds 24 integration cases covering the new standard, Hybrid, mixed-host, navigation, messaging, screenshot, console, recreation, and layout behavior. The PR description also reports focused local matrix coverage; CI was not yet complete.
|
368e369 to
d1321cd
Compare
|
Consolidation is complete. This remains a draft PR above #664, at head #671 -> #674 -> #673 -> #672 -> #669 -> #670 -> #661 -> #662 -> #664 -> #665. Superseded bundles #660 and #655 are closed without merging. All ten replacements remain draft for individual full review; no implementation PR was marked ready or merged. Fresh complete-graph evidence: the maintained Mac Catalyst matrix passes 44/44; actual CLI and stdio MCP exercise selected source, evaluation, native PNGs, input/readback, original Hybrid messaging, navigation/reload, generic layout inclusion/exclusion and failure exits. The focused Agent/CLI/portable Client, managed GTK startup and Chromium consumer selections pass. This sample layer is the unchanged nine-file patch; lower fixes were not replayed or bundled back into it. Limits retained for review: five whole WebViewTests class runs were 17/17, 17/17, 16/17, 17/17, 17/17. The one failure occurs in native UI snapshot reading during navigation, before selected filling; the screenshot case passes all five. Eleven optional consumer tests fail before requests when their fake listener binds 127.0.0.9 on this Mac. One separately configured Layout QA journey is skipped. The expanded selection totals 613 passed, 12 failed, 1 skipped; no full-green, screenshot-flake/native-crash cure, or untested-platform claim. Original logs and reproduction evidence are retained. |
d1321cd to
3f5cd58
Compare
3f5cd58 to
7d2ec6c
Compare
7d2ec6c to
54b5df4
Compare
Exercise standard, Hybrid and Blazor hosts independently and together with real state, original messaging, navigation, native captures and DOM layout diagnostics. Keep linked backend Shells unchanged through optional sample-page registration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fdd755ff-5a3d-4198-9b31-408f603c0442
54b5df4 to
6bad880
Compare
Summary
Add maintained sample pages and repeatable integration coverage for standard WebView, packaged HybridWebView and mixed standard/Hybrid/Blazor hosts.
AppShell.xaml.cshook so linked AppKit/GTK/WPF Shells retain their existing routes without compiling these pages. Registration remains Debug-only and exercises idempotency.The production changes are limited to sample pages/resources/registration and their usage documentation; the remaining changes are integration tests and the owned HTTP fixture.
Validation
On the rebuilt Mac Catalyst sample, the maintained matrix passes 44/44: 24 new generic cases, the complete current 17-case WebViewTests class, two native cases and a native layout baseline. Real CLI and stdio MCP calls verify selected source/evaluation/input, useful errors, failure exits and six decoded, nonblank, owner-sized native PNGs. Additional native checks verify exact input/change counts, real Blazor component state, Hybrid messaging and DOM inclusion/exclusion. Sample/integration graphs and portable Client build successfully.
Five complete WebViewTests repetitions are 17/17, 17/17, 16/17, 17/17, 17/17. The retained failure occurs in native snapshot reading while navigating to the multi-Blazor page, before selected filling; screenshots pass all five. No retry-away, weakened assertion or native-capture change is used.
The expanded selection totals 613 passed, 12 failed, 1 skipped. Besides that native read failure, 11 optional consumers fail before requests when their fake listener binds
127.0.0.9on this Mac; a separately configured Layout QA journey is skipped. No full-green claim is made. Evidence covers Mac Catalyst and Chromium, not Android/iOS/Windows/AppKit/native GTK/WPF/net472 or physical devices. Owned helpers are stopped.Related: #621, #232, #407, #654. These are regression/context links, not claims to resolve the original timing, intermittent screenshot/native-crash or broader documentation issues.