Repository navigation
Remove misleading WebView network alias - #694
Open
mattleibow wants to merge 4 commits into
Open
mattleibow wants to merge 4 commits into
mattleibow wants to merge 4 commits into
Conversation
Return the standard unsupported browser-network envelope instead of native traffic under the WebView route. Preserve native request endpoints and align capability examples, docs, and focused tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b2bd9105-f47b-4c5b-b5b9-11740d943d70
mattleibow
added
breaking-change
This comment has been minimized.
This comment has been minimized.
Remove the unused browser-network route and handler instead of retaining an unsupported placeholder. Keep native HTTP capture unchanged and align the protocol, regression tests, and CLI mock with the default 404 response. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b2bd9105-f47b-4c5b-b5b9-11740d943d70
mattleibow
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b2bd9105-f47b-4c5b-b5b9-11740d943d70
mattleibow
marked this pull request as ready for review
October 14, 2026 21:14
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b2bd9105-f47b-4c5b-b5b9-11740d943d70
Contributor
|
✅ Expert Code Review: 2 independent reviewers found no issues. Methodology: 2-model adversarial consensus. (1 reviewer failed to complete — reduced coverage, no tiebreaker)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove
/api/v1/webview/network, a misleading alias of the native .NET request store. It never captured browser fetch/XHR traffic or associated requests with a WebView context.Remove the route, handler, OpenAPI entry, stale protocol README paragraph, CLI mock route, and
networkfrom the WebView capability/example. No new endpoint, capture feature, options, or removal-specific tests are added.Breaking behavior: callers of the old HTTP 200 alias now receive the server's normal HTTP 404. Use
/api/v1/network/requestsfor native .NET HTTP traffic; its implementation remains unchanged.Validation
On the latest revision, the existing protocol and CDP registry tests passed: 8 passed, 0 failed, 0 skipped. The CLI integration suite passed after the mock-route removal: 40 passed, 0 failed, 0 skipped. Hosted CI results from earlier heads are not validation of this revision.
Integration
The generic WebView implementation does not depend on this route. The sample test in #665,
Layout_GenericHost_ReportsMeasuredDomDefectsAndHonestCapabilities, currently expects HTTP 501 and needs reconciliation when integrated. This PR does not change the original stack.