Repository navigation
ci: run CI on Node.js ^22.23.4 for the eMudhra CA fix - #197
Merged
Merged
Conversation
Bracciata
marked this pull request as ready for review
October 21, 2026 23:43
maksym-shynkarenko
approved these changes
Oct 22, 2026
Bracciata
added a commit
that referenced
this pull request
Nov 13, 2026
…nd (#199) `run-devhub-action` has failed on every PR since at least 2026-10-21 (#196, #197, #198): `Unexpected outcome: success, issue_count: 0`. **Cause:** the job scanned `the-internet.herokuapp.com/login` through `watcher-examples`. That third-party page now has no WCAG 2.x A/AA violations (I ran axe 4.13 on it locally: none). So DevHub correctly reports 0, the action passes, and the "expected failure" check fails. Nothing in this repo or `watcher-examples` changed. **Fix:** scan a page we control. `ci/watcher-fixture/fixture.html` has four deliberate violations: `button-name`, `html-has-lang`, `image-alt` and `label`. `scan.mjs` serves it on `127.0.0.1` and scans it with `@axe-core/watcher` 4.7.0 and `playwright` 1.64.1, both pinned with a lockfile. The job checks out this repo (not `watcher-examples`) and names the branch, because Watcher would otherwise record it as `HEAD`. The dev test project is locked to `watcher-examples` and refuses other repositories, so the step sets `origin` to that URL rather than minting a new project and secrets. The fixture lives outside `test/` so that `node --test test/` doesn't pick up `scan.mjs`. **Acceptance criteria** - `run-devhub-action` reports more than 0 violations on the fixture, and "Verify expected failure" passes. - Exactly one sticky axe DevHub comment is left on the PR. - The existing dev test project accepts the run, with no new secrets. - Dependabot covers the fixture's npm manifest, including `@axe-core/watcher`. **Also in this PR:** the job is renamed `scan-watcher-fixture` (it runs no tests now), it gets a read-only token that isn't persisted in the checkout, and `.github/dependabot.yml` now points its npm entry at `ci/watcher-fixture`. The root entry covered no manifest, and it ignored `@axe-core/watcher` for a workflow that doesn't exist. **Verified locally:** axe finds the four violations on the fixture. With a fake key, `scan.mjs` gets as far as session init (`Invalid API key`). `node --test test/` passes 24/24. On this PR's CI, `run-devhub-action` found 4 violations, failed as expected, and left exactly one sticky comment. No QA required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets both
actions/setup-nodesteps intests.ymlto^22.23.4withcheck-latest: true. 22.23.4 is the first 22.x that distrusts the compromised eMudhra intermediate CAs. A bare22can reuse an older build cached on the runner. The range keeps that floor, andcheck-latestpicks up later 22.x security releases. A namednode --versionstep prints the version in each run's log (v22.23.4on this PR).The action itself is a composite of shell scripts and ships no Node runtime, so CI is the only place Node runs.
run-devhub-actionis red, but not because of this PR.main's Tests workflow has failed on every run since at least 2025-12. Here DevHub reports 0 violations for the watcher-examples commit, so "Verify expected failure" trips. The action under test is shell and curl and doesn't use Node.Part of dequelabs/results-team#583.
Closes #196