Skip to content

ci: run CI on Node.js ^22.23.4 for the eMudhra CA fix - #197

Merged
Bracciata merged 4 commits into
mainfrom
chore/issue-196
Oct 22, 2026
Merged

Bracciata merged 4 commits into
mainfrom
chore/issue-196

Conversation

@Bracciata

@Bracciata Bracciata commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sets both actions/setup-node steps in tests.yml to ^22.23.4 with check-latest: true. 22.23.4 is the first 22.x that distrusts the compromised eMudhra intermediate CAs. A bare 22 can reuse an older build cached on the runner. The range keeps that floor, and check-latest picks up later 22.x security releases. A named node --version step prints the version in each run's log (v22.23.4 on this PR).

The action itself is a composite of shell scripts and ships no Node runtime, so CI is the only place Node runs.

run-devhub-action is red, but not because of this PR. main's Tests workflow has failed on every run since at least 2025-12. Here DevHub reports 0 violations for the watcher-examples commit, so "Verify expected failure" trips. The action under test is shell and curl and doesn't use Node.

Part of dequelabs/results-team#583.

Closes #196

@Bracciata Bracciata changed the title ci: pin Node.js 22.23.4 for the eMudhra CA fix ci: require Node.js >=22.23.4 for the eMudhra CA fix Oct 21, 2026
@Bracciata Bracciata changed the title ci: require Node.js >=22.23.4 for the eMudhra CA fix ci: run CI on Node.js ^22.23.4 for the eMudhra CA fix Oct 21, 2026
@Bracciata
Bracciata marked this pull request as ready for review October 21, 2026 23:43
@Bracciata
Bracciata requested a review from a team as a code owner October 21, 2026 23:43
@Bracciata Bracciata added the team-results Results team ticket label Oct 21, 2026
@Bracciata
Bracciata merged commit fc36b5a into main Oct 22, 2026
10 of 11 checks passed
@Bracciata
Bracciata deleted the chore/issue-196 branch October 22, 2026 13:07
Bracciata added a commit that referenced this pull request Nov 13, 2026
…nd (#199)

`run-devhub-action` has failed on every PR since at least 2026-10-21
(#196, #197, #198): `Unexpected outcome: success, issue_count: 0`.

**Cause:** the job scanned `the-internet.herokuapp.com/login` through
`watcher-examples`. That third-party page now has no WCAG 2.x A/AA
violations (I ran axe 4.13 on it locally: none). So DevHub correctly
reports 0, the action passes, and the "expected failure" check fails.
Nothing in this repo or `watcher-examples` changed.

**Fix:** scan a page we control. `ci/watcher-fixture/fixture.html` has
four deliberate violations: `button-name`, `html-has-lang`, `image-alt`
and `label`. `scan.mjs` serves it on `127.0.0.1` and scans it with
`@axe-core/watcher` 4.7.0 and `playwright` 1.64.1, both pinned with a
lockfile. The job checks out this repo (not `watcher-examples`) and
names the branch, because Watcher would otherwise record it as `HEAD`.
The dev test project is locked to `watcher-examples` and refuses other
repositories, so the step sets `origin` to that URL rather than minting
a new project and secrets. The fixture lives outside `test/` so that
`node --test test/` doesn't pick up `scan.mjs`.

**Acceptance criteria**
- `run-devhub-action` reports more than 0 violations on the fixture, and
"Verify expected failure" passes.
- Exactly one sticky axe DevHub comment is left on the PR.
- The existing dev test project accepts the run, with no new secrets.
- Dependabot covers the fixture's npm manifest, including
`@axe-core/watcher`.

**Also in this PR:** the job is renamed `scan-watcher-fixture` (it runs
no tests now), it gets a read-only token that isn't persisted in the
checkout, and `.github/dependabot.yml` now points its npm entry at
`ci/watcher-fixture`. The root entry covered no manifest, and it ignored
`@axe-core/watcher` for a workflow that doesn't exist.

**Verified locally:** axe finds the four violations on the fixture. With
a fake key, `scan.mjs` gets as far as session init (`Invalid API key`).
`node --test test/` passes 24/24. On this PR's CI, `run-devhub-action`
found 4 violations, failed as expected, and left exactly one sticky
comment.

No QA required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-results Results team ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm CI runs a patched Node.js (eMudhra CA key compromise)

2 participants