Repository navigation
ci: accept a clean 0-violation outcome from the watcher-examples scan - #199
Merged
Merged
Conversation
The job scanned the-internet.herokuapp.com/login via watcher-examples. That page now has no WCAG 2.x A/AA violations, so the action correctly passed and "Verify expected failure" has failed every PR since at least 2026-10-21. Scan ci/watcher-fixture/fixture.html instead: four deliberate violations (button-name, html-has-lang, image-alt, label), served on 127.0.0.1 and scanned with pinned @axe-core/watcher 4.7.0 + playwright 1.64.1. No QA required
The dev test project is locked to dequelabs/watcher-examples and refused the run: "This project is locked to a different repository". No QA required
This comment has been minimized.
This comment has been minimized.
- Point the npm Dependabot entry at ci/watcher-fixture, the only npm manifest, and stop ignoring @axe-core/watcher there, so CI keeps scanning with the release customers install. - Rename run-watcher-tests to scan-watcher-fixture; it runs no tests now. - Give that job a read-only token and don't persist it in the checkout. - Match scan.mjs to test/pr-comment.test.mjs style. No QA required
Bracciata
marked this pull request as ready for review
November 12, 2026 15:54
Bracciata
enabled auto-merge (squash)
November 12, 2026 15:58
Zidious
requested changes
Nov 12, 2026
Zidious
left a comment
Contributor
There was a problem hiding this comment.
We should not maintain fixtures here
Zidious
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run-devhub-actionhas failed on every PR since at least 2026-10-21 (#196, #197, #198):Unexpected outcome: success, issue_count: 0.Cause: the job scans
the-internet.herokuapp.com/loginthroughwatcher-examples, and that page no longer has WCAG 2.x A/AA violations. DevHub correctly reports 0 and the action passes, but "Verify expected failure" required a failure.Fix: treat the clean result as the expected one, in line with #182 (this repo's CI points at
watcher-examplesrather than keeping its own example). The job now asserts the action succeeds withissue_count0 and setsproject_idandaxe_url. The sticky-comment step now checks the success path: no visible axe DevHub comment is left, because the action hides any earlier one.Only
.github/workflows/tests.ymlchanges againstmain. The earlier in-repo fixture, its scan job and the Dependabot change were dropped after review.Follow-up (not in this PR): if we want CI to cover the failure path again, add an example with known violations to
watcher-examplesand test it from a separate workflow.Verified locally:
actionlintis clean, andnode --test test/passes 24/24. I ran the GraphQL comment count against this PR, and it found the one visible comment left by the earlier fixture run.No QA required