Skip to content

Add extended KNX smoke alarm support (Gira): extra fault channels, temperature, siren control, and fault acknowledge#85

Open
wlcrs wants to merge 7 commits into
athombv:masterfrom
wlcrs:extended_smoke_alarm_support
Open

Add extended KNX smoke alarm support (Gira): extra fault channels, temperature, siren control, and fault acknowledge#85
wlcrs wants to merge 7 commits into
athombv:masterfrom
wlcrs:extended_smoke_alarm_support

Conversation

@wlcrs

@wlcrs wlcrs commented May 15, 2026

Copy link
Copy Markdown

Hi Homey team,

This PR extends the KNX smoke sensor device to support the full set of relevant group addresses exposed by Gira smoke alarm objects, beyond the previously supported smoke-only channel. All new functions are implemented as optional.

This PDF documents the newly implemented KNX objects:
gira_knx_documentation.pdf

What was added:

  • Support for additional smoke-alarm related addresses:
    • General alarm
    • Heat alarm
    • Signal: a writable object to start/stop the siren (uiQuickAction disabled because of that)
    • Temperature
    • Battery fault
    • 230V fault
    • Smoke sensor fault
    • Temperature sensor fault
    • Fault acknowledge
  • Dynamic capability handling based on configured group addresses (only show capabilities that are configured).
  • Pairing and settings updates to configure all supported smoke sensor addresses in a clear order.
  • Localized labels for the new smoke sensor fields.

Screenshots

image image image

@ttherbrink

ttherbrink commented May 26, 2026

Copy link
Copy Markdown
Contributor

Very good looking PR.

Just a few things:
Please include an icon for the new sensor capabilities, You can request them here if designing is not your strong suit (https://github.com/athombv/homey-vectors-public)
Please resolve the linting error's
For future pr's refrain from large formatting changes in existing code. This makes the changes less visible and more difficult to asses.

When resolved i will include this pr in the next release cycle

ttherbrink
ttherbrink reviewed May 26, 2026
View reviewed changes
Comment thread .homeycompose/capabilities/knx_acknowledge_fault.json Outdated
"uiComponent": "button",
"title": {
"en": "Acknowledge fault",
"nl": "Fout bevestigen",

@ttherbrink ttherbrink May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarification what does this button do? The title is not very clear to me

@LaurensVanAcker LaurensVanAcker May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttherbrink, It resets the fault thrown

@ttherbrink ttherbrink May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this makes the fault reset to false it would make more sense to me to name it reset faults. this makes it clearer to the user what happens when the button is pressen

@LaurensVanAcker LaurensVanAcker May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call — renamed in 0a0411d: the capability title is now Reset faults (translated to all 13 languages), and the pairing-UI GA label is now Reset faults address. Capability ID and setting key are kept as knx_acknowledge_fault / ga_acknowledge_fault to stay aligned with the KNX object name on the bus.

LaurensVanAcker added a commit to LaurensVanAcker/homey-vectors-public that referenced this pull request May 26, 2026
@LaurensVanAcker
Add fault icons for org.knx (KNX) smoke sensor capabilities
9e6922c 
For PR athombv/org.knx#85, which extends the KNX smoke sensor with
extra fault and signalling channels exposed by Gira smoke alarms.

Adds 4 monochrome 64x64 SVGs for the new capabilities:
- knx_failure_smoke      (smoke sensor failure)
- knx_failure_temperature (temperature sensor failure)
- knx_failure_230v        (230V power failure)
- knx_acknowledge_fault   (reset/acknowledge button)

The alarm_signal (siren) capability reuses the existing
"homey capability Icons/alarm_siren.svg" — no new file needed.
@LaurensVanAcker LaurensVanAcker mentioned this pull request May 26, 2026
Closed
@LaurensVanAcker

LaurensVanAcker commented May 26, 2026

Copy link
Copy Markdown

Very good looking PR.

Just a few things: Please include an icon for the new sensor capabilities, You can request them here if designing is not your strong suit (https://github.com/athombv/homey-vectors-public) Please resolve the linting error's For future pr's refrain from large formatting changes in existing code. This makes the changes less visible and more difficult to asses.

When resolved i will include this pr in the next release cycle

@ttherbrink @wlcrs I have added the new logo's here: athombv/homey-vectors-public#410

@ttherbrink

ttherbrink commented May 26, 2026

Copy link
Copy Markdown
Contributor

I think you misunderstood the part about the icons. Icons should be included in the app using the "icon" prop in the custom capability https://apps.developer.homey.app/the-basics/devices/capabilities#custom-capabilities
The design guidelines can be found here: https://apps.developer.homey.app/app-store/guidelines

@LaurensVanAcker
Add icons for new smoke-sensor capabilities
0a0411d 
Addresses review feedback from @ttherbrink:
- Add monochrome SVG icons for the new sensor capabilities, wired
  via the "icon" prop in each capability JSON.
- alarm_signal reuses the official athombv/homey-vectors-public
  alarm_siren.svg.
- Rename "Acknowledge fault" -> "Reset faults" — clearer for the
  user about what pressing the button does (in 13 languages).
@LaurensVanAcker
Update locale labels for renamed acknowledge_fault GA (ar/da/de/en)
022eaf5 
Match the new "Reset faults" capability title in the pairing UI labels.
@LaurensVanAcker
Update locale labels for renamed acknowledge_fault GA (es/fr/it/ko/nl)
1c5cc29
@LaurensVanAcker
Update locale labels for renamed acknowledge_fault GA (no/pl/ru/sv)
3ad2651
@LaurensVanAcker
Revert format churn in pairing UI; keep only smoke-sensor additions
8226866 
Addresses @ttherbrink: refrain from large formatting changes in
existing code. Rebuilt the file from master and added only the
functional changes — the smoke-sensor fieldset, the case branch in
displayDeviceTypeFields, and the case branch in the save handler.
@LaurensVanAcker

LaurensVanAcker commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Thanks @ttherbrink, all feedback addressed. Summary of what was pushed:

  • Icons — moved into the app at assets/capabilities/ (sorry for the detour via homey-vectors-public earlier — I closed that PR). All 5 new capabilities now reference their icon via the "icon" prop in the capability JSON:
    • knx_failure_smoke.svg, knx_failure_temperature.svg, knx_failure_230v.svg, knx_acknowledge_fault.svg — drafted in the same monochrome 64x64 style as the existing fan_auto_mode.svg.
    • knx_alarm_signal reuses the official alarm_siren.svg from homey-vectors-public/homey capability Icons/.
    • Happy to swap any of them out if the design team prefers a different direction.
  • Linting — eslint --fix applied; npm run lint now passes with 0 errors (5 remaining warnings are pre-existing no-console in lib/).
  • Formatting churn — select_groupaddresses/index.html rebuilt from master; only the smoke-sensor fieldset and the two case 'smoke_sensor': branches were added. Diff is now ~100 lines instead of ~800.
  • Acknowledge fault title — renamed to Reset faults everywhere (capability title + GA label in 13 locales); see thread.

@ttherbrink ttherbrink mentioned this pull request Jul 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttherbrink ttherbrink ttherbrink requested changes
+1 more reviewer
@LaurensVanAcker LaurensVanAcker LaurensVanAcker left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wlcrs @ttherbrink @LaurensVanAcker