Extended smoke alarm support#89
Open
ttherbrink wants to merge 8 commits into
Open
Conversation
Addresses review feedback from @ttherbrink: - Add monochrome SVG icons for the new sensor capabilities, wired via the "icon" prop in each capability JSON. - alarm_signal reuses the official athombv/homey-vectors-public alarm_siren.svg. - Rename "Acknowledge fault" -> "Reset faults" — clearer for the user about what pressing the button does (in 13 languages).
Match the new "Reset faults" capability title in the pairing UI labels.
Addresses @ttherbrink: refrain from large formatting changes in existing code. Rebuilt the file from master and added only the functional changes — the smoke-sensor fieldset, the case branch in displayDeviceTypeFields, and the case branch in the save handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #85