Repository navigation
Conversation
…alled Client: build Apache.Thrift.Compiler targets net8.0 and set no RollForward, so on a machine with only .NET 9 or 10 the tool installed and then refused to start, asking for .NET 8. With RollForward=Major the launcher uses the next newer .NET when 8 is missing; where 8 is installed, nothing changes. test-dotnet-tool.ps1 now checks the runtimeconfig.json in the package. The CI runners have .NET 8 next to newer versions, so installing and running the tool there could not show the problem. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mergeable
Bot
added
the
build and general CI
2 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6440
Apache.Thrift.Compilertargetsnet8.0and set noRollForward. On a machine with only .NET 9 or 10,dotnet tool install --global Apache.Thrift.Compilertherefore succeeded, andthriftthen refused to start: "You must install or update .NET to run this application", asking forMicrosoft.NETCore.App8.0.0.Apache.Thrift.Compiler.csproj:<RollForward>Major</RollForward>. The launcher uses the next newer .NET when 8 is missing; where 8 is installed, nothing changes.test-dotnet-tool.ps1: checks that the packedruntimeconfig.jsonallows that roll forward. The install-and-run step cannot show the problem on the CI runners, because they have .NET 8: it passed there with the unfixed package.build/windows/README.mddescribes both.Checked in the official SDK images: packed from this branch with the 0.25.0
thrift.exeas payload, thentest-dotnet-tool.ps1run on the package.mcr.microsoft.com/dotnet/sdk:10.0, only .NET 10mcr.microsoft.com/dotnet/sdk:9.0, only .NET 9mcr.microsoft.com/dotnet/sdk:8.0, only .NET 8The published 0.25.0 package fails the same 4 checks in the .NET 10 image. It cannot be changed any more; #4033 tells README readers to reinstall it with
--allow-roll-forward.🤖 Generated with Claude Code