Skip to content

THRIFT-6402: Build pull requests on one macOS image #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slachiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −3
Open

THRIFT-6402: Build pull requests on one macOS image #3998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ on:
pull_request:
branches: ["*"]

# A new push to a pull request supersedes its running build. Each push to a
# branch gets a group of its own, so no commit on master loses its run.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.ref || github.run_id }}
cancel-in-progress: true

env:
BUILD_DEPS: automake bison flex git libboost-all-dev libevent-dev libssl-dev libtool make pkg-config
CONFIG_ARGS_FOR_LIBS: >
Expand Down Expand Up @@ -134,7 +140,9 @@ jobs:
compiler-macos:
strategy:
matrix:
os: &macos_versions [macos-15-intel, macos-14, macos-15, macos-26]
# The full set runs on pushes to apache/thrift. Pull requests and pushes
# to forks build on one image; the others catch up after merge.
os: &macos_versions ${{ fromJSON(github.event_name == 'push' && github.repository == 'apache/thrift' && '["macos-15-intel", "macos-14", "macos-15", "macos-26"]' || '["macos-15"]') }}
fail-fast: false
runs-on: ${{ matrix.os }}
timeout-minutes: 60
Expand Down Expand Up @@ -787,7 +795,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
python-version: &python_versions ["3.10", "3.11", "3.12", "3.13", "3.14"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
fail-fast: false
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down Expand Up @@ -866,7 +874,9 @@ jobs:
strategy:
matrix:
os: *macos_versions
python-version: *python_versions
# lib-python covers every version on Linux. Outside pushes to
# apache/thrift, macOS tests only the oldest and newest.
python-version: ${{ fromJSON(github.event_name == 'push' && github.repository == 'apache/thrift' && '["3.10", "3.11", "3.12", "3.13", "3.14"]' || '["3.10", "3.14"]') }}
fail-fast: false
runs-on: ${{ matrix.os }}
timeout-minutes: 20
Expand Down
Loading