Repository navigation
THRIFT-6402: Build pull requests on one macOS image - #3998
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Client: build Pull requests and fork pushes run 3 macOS jobs instead of 24; the full matrix still runs on every push to apache/thrift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mergeable
Bot
added
the
github_actions
slachiewicz
marked this pull request as ready for review
October 2, 2026 16:55
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Shared push concurrency groups can cancel pending upstream builds during rapid pushes.
Review effort: Balanced
Findings: 1
What changed in this PR
Reduces macOS CI load for pull requests and fork pushes while retaining full upstream coverage.
Changes:
- Adds event-aware workflow concurrency.
- Limits non-upstream macOS builds to
macos-15. - Tests Python 3.10 and 3.14 on reduced macOS builds.
| File | Description |
|---|---|
.github/workflows/build.yml |
Adjusts concurrency and macOS/Python matrices. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+11
to
+13
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests and fork pushes now build on
macos-15with Python 3.10 and 3.14, which is 3 macOS jobs instead of 24. The full matrix still runs on every push toapache/thrift. A new push to a pull request also cancels that PR's older run. Committer branches pushed toapache/thriftstill build twice (push and PR); this PR doesn't change triggers.Verified:
actionlint1.7.12 → no findings.[skip ci]anywhere in the commit message to free up build resources.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com