Skip to content

fix(docs): use modern driver package for CrateDB - #42125

Merged
hainenber merged 1 commit into
masterfrom
adopt/38358-followup
Jul 18, 2026
Merged

fix(docs): use modern driver package for CrateDB#42125
hainenber merged 1 commit into
masterfrom
adopt/38358-followup

Conversation

@rusackas

@rusackas rusackas commented Jul 17, 2026

Copy link
Copy Markdown
Member

SUMMARY

Adopts #38358 from @amotl. The docs page for CrateDB still pointed at the legacy crate[sqlalchemy] driver package in the driver block's pypi_package field, a leftover from the sqlalchemy-cratedb migration in #29243. The homepage URL and top-level pypi_packages list had already been updated elsewhere, so this just fixes the one remaining spot and adds the UPDATING.md line the original PR proposed.

amotl can't enable maintainer edits on the original branch and lost access to the fork, so recycling the change here per the discussion on #38358.

TESTING INSTRUCTIONS

N/A, docs/metadata only. ruff, black, and the db-engine-spec-metadata pre-commit hook all pass on the change.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas @amotl @claude
fix(docs): use modern driver package for CrateDB
edb6c34 
Update the remaining `crate[sqlalchemy]` driver reference to
`sqlalchemy-cratedb`, a leftover from the earlier migration off the
legacy package, and add the corresponding UPDATING.md entry.

Supersedes #38358

Co-Authored-By: Andreas Motl <andreas.motl@crate.io>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dosubot dosubot Bot added the doc:user User / Superset documentation label Jul 17, 2026
@rusackas rusackas mentioned this pull request Jul 17, 2026
Closed
@bito-code-review

bito-code-review Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #11a3c3

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: edb6c34..edb6c34
    • superset/db_engine_specs/crate.py
  • Files skipped - 2
    • UPDATING.md - Reason: Filter setting
    • docs/src/data/databases.json - Reason: Filter setting
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added the doc Namespace | Anything related to documentation label Jul 17, 2026
@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit edb6c34
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a59baab5839910008bb6acf
😎 Deploy Preview https://deploy-preview-42125--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (f467d36) to head (edb6c34).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #42125      +/-   ##
==========================================
- Coverage   65.14%   65.13%   -0.01%     
==========================================
  Files        2753     2753              
  Lines      154521   154565      +44     
  Branches    35443    35449       +6     
==========================================
+ Hits       100656   100670      +14     
- Misses      51953    51981      +28     
- Partials     1912     1914       +2
Flag Coverage Δ
hive 39.00% <ø> (-0.02%) ⬇️
mysql 57.72% <ø> (-0.02%) ⬇️
postgres 57.78% <ø> (-0.02%) ⬇️
presto 40.97% <ø> (-0.02%) ⬇️
python 59.21% <ø> (-0.02%) ⬇️
sqlite 57.39% <ø> (-0.02%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

amotl
amotl approved these changes Jul 17, 2026
View reviewed changes

@amotl amotl left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rusackas! 💯

/cc @kneth, @florinutz, @bgunebakan

@bgunebakan

bgunebakan commented Jul 17, 2026

Copy link
Copy Markdown

Thank you!

@hainenber
hainenber merged commit b432f8c into master Jul 18, 2026
62 checks passed
@hainenber
hainenber deleted the adopt/38358-followup branch July 18, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hainenber hainenber hainenber approved these changes
@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe
@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina
+1 more reviewer
@amotl amotl amotl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc:user User / Superset documentation doc Namespace | Anything related to documentation size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rusackas @bgunebakan @amotl @hainenber