fix(docs): Use modern driver package for CrateDB - #38358
Conversation
Code Review Agent Run #e4987eActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
dosubot
Bot
added
the
data:connect
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (99.92%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #38358 +/- ##
==========================================
- Coverage 65.30% 64.39% -0.91%
==========================================
Files 1819 2532 +713
Lines 72745 129896 +57151
Branches 23266 30048 +6782
==========================================
+ Hits 47505 83651 +36146
- Misses 25240 44789 +19549
- Partials 0 1456 +1456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| "name": "crate", | ||
| "pypi_package": "crate[sqlalchemy]", | ||
| "pypi_package": "sqlalchemy-cratedb", |
There was a problem hiding this comment.
Can you add a line item in UPDATING.md about switching the pypi package?
There was a problem hiding this comment.
Sure, thank you. I've just updated the patch as you suggested, cherry-picking the proposal by the code review bot.
There was a problem hiding this comment.
Hi @sadpandajoe. Do you think the patch is eligible for merging now? Will you take care about backporting it to earlier active maintenance branches of Apache Superset, for example by using Mergify, or shall we do it manually after this patch got merged?
There was a problem hiding this comment.
Hi again. Please let us know if this patch needs any further love. Thank you!
|
The PR switches the CrateDB PyPI package from 'crate[sqlalchemy]' to 'sqlalchemy-cratedb'. Here's a suggested line item for UPDATING.md to document this change. UPDATING.md |
Code Review Agent Run #7a9076Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
codeant-ai-for-open-source
Bot
added
the
size:XS
Code Review Agent Run #7e3602Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
I'll see if I an get this to pass CI, so we can merge it. LGTM
|
@amotl I had a go at rebasing this to clear the conflicts so it could land, but I can't push, looks like "Allow edits by maintainers" isn't enabled on this one. Could you rebase on current While I was in there I noticed most of this seems to have landed already (homepage is |
|
Hi @rusackas. Thank you for pinging me. @florinutz: Could you take over my branch and bring it to completion according to the suggestions by Evan? 🙏 |
|
Heya... just checking in. Happy to "adopt" the work here on a new PR if time isn't available or flipping on maintainer commits can't be enabled. |
|
Hi Evan. Thanks for your swift reply. I can't turn on maintainer commits, and lost access to |
|
Will do! Thanks for lining up the shot :D |
|
Brought this forward as #42125, closing this one out. Thanks again for flagging it! |
3 participants
User description
Dear Superset maintainers,
on the documentation page about CrateDB, we discovered a possible leftover from the migration from
crate[sqlalchemy]tosqlalchemy-cratedbthe other day.Other than merging to
master, can you possibly commandeer this patch to be backported to earlier releases of Superset? Thank you in advance!With kind regards,
Andreas.
CodeAnt-AI Description
Use sqlalchemy-cratedb as the recommended CrateDB driver and update CrateDB homepage link
What Changed
crate[sqlalchemy]tosqlalchemy-cratedbin engine specs and documentation entrieshttps://crate.io/tohttps://cratedb.com/Impact
✅ Clearer CrateDB install instructions✅ Fewer driver installation mismatches✅ Accurate CrateDB homepage link💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.