RDP/rdpsnd: add Wave2 audio compatibility for modern FreeRDP/GRD servers#680
Open
chrilep wants to merge 3 commits into
Open
RDP/rdpsnd: add Wave2 audio compatibility for modern FreeRDP/GRD servers#680chrilep wants to merge 3 commits into
chrilep wants to merge 3 commits into
Conversation
Contributor
|
@chrilep Thank you for the contribution to the project. As a starting point, you will need to submit a Jira issue for these changes (and apply for a Jira account, if you don't already have one) and then prefix both the PR title and the commit messages with the Jira issue. https://issues.apache.org/jira/browse/GUACAMOLE You can see full contribution guidelines, here: https://guacamole.apache.org/open-source/ And you can look at other open pull requests to see examples of how that looks once you have your Jira issue. |
Author
|
Aye, I registered at Jira. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility for
SNDC_WAVE2in the RDPrdpsndchannel and updates negotiated rdpsnd version handling so audio works with modern server implementations (including GNOME Remote Desktop / FreeRDP-based paths) that use Wave2 semantics.Problem
In affected environments, RDP audio negotiation succeeds but audio payloads arrive in
SNDC_WAVE2format while Guacamole only handled classicSNDC_WAVE. Result: no audio in Guacamole despite successful session setup.Change
SNDC_WAVE2handling in rdpsnd message dispatchImpact
Scope
Targeted protocol compatibility update in rdpsnd path only.
AI Assistance Disclosure
Parts of this contribution (analysis and code drafting) were created with assistance from GitHub Copilot (GPT-5.3-Codex) and then reviewed/refined before submission.