RDP/settings: avoid divide-by-zero when optimal client resolution is unavailable#681
Open
chrilep wants to merge 1 commit into
Open
RDP/settings: avoid divide-by-zero when optimal client resolution is unavailable#681chrilep wants to merge 1 commit into
chrilep wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents a divide-by-zero in
guac_rdp_parse_args()when client handshake data does not provide a validoptimal_resolution.Problem
settings->widthandsettings->heightwere derived using:... / user->info.optimal_resolutionIf
optimal_resolutionis0, this can trigger SIGFPE.Change
if (user->info.optimal_resolution > 0)RDP_DEFAULT_WIDTH,RDP_DEFAULT_HEIGHT) otherwiseBehavior
optimal_resolutionScope
Focused bugfix only; no protocol or feature changes.
AI Assistance Disclosure
Parts of this contribution (analysis and code drafting) were created with assistance from GitHub Copilot (GPT-5.3-Codex) and then reviewed/refined before submission.