Skip to content

Record feedback issue retention in the feedback contract - #52

Merged
MHohlios merged 1 commit into
mainfrom
wiffletree/record-feedback-issue-retention-in-the-feedback
Oct 20, 2026
Merged

MHohlios merged 1 commit into
mainfrom
wiffletree/record-feedback-issue-retention-in-the-feedback

Conversation

@MHohlios

Copy link
Copy Markdown
Contributor

What and why

The Reviso privacy policy on vyttle.com now promises how long feedback issues are kept. The feedback contract should say the same. Add a Retention section: issues are closed once we have looked at them and deleted a year after filing; anyone can email privacy@vyttle.com with a link to have theirs deleted sooner; copies made before deletion, such as search-engine caches or GitHub notification emails, may remain outside our control.

Not settled here: the contract's last paragraph says eval-candidate issues become eval cases, and a case committed to eval/corpus/ would outlive its deleted issue. Whether derived cases are deleted with their source issue, or the policy says what is kept, is still open and will follow separately.

Does this change what Reviso says to people?

  • No, this doesn't affect review output
  • Yes — eval results below

Checklist

  • Commits are signed off (git commit -s) — see CONTRIBUTING.md
  • One concern per PR
  • Docs updated if behaviour changed

Validation: markdownlint-cli2 and lychee (CI args) pass, as do the portability, matcher and gold-judge tests.

Feedback issues are public, so the contract now states how long they stay: closed once triaged, deleted a year after filing, deleted sooner on request, and copies made before deletion may remain outside our control.

Signed-off-by: Michael Hohlios <michael@vyttle.com>
@MHohlios
MHohlios force-pushed the wiffletree/record-feedback-issue-retention-in-the-feedback branch from 6dfa0ae to 1228086 Compare October 20, 2026 20:41
@MHohlios
MHohlios merged commit 609cc7d into main Oct 20, 2026
2 checks passed
@MHohlios
MHohlios deleted the wiffletree/record-feedback-issue-retention-in-the-feedback branch October 20, 2026 20:47
MHohlios added a commit that referenced this pull request Oct 20, 2026
## What and why

Follows #52, which added a Retention section to the feedback contract
and left one question open: an eval case built from a feedback issue
would outlive the issue we promise to delete. Decision: derived eval
cases are deleted with their source issue.

- Contract (`skills/reviso/references/contracts/feedback.md`): derived
cases are deleted with the issue, from the public and private corpora
alike. Removing an entry does not rewrite git history, so earlier
commits still contain it; the contract says so rather than promising a
rewrite. The `eval-candidate` pipeline link now points at the corpus
intake notes instead of `docs/evals.md`, which never described that
pipeline.
- `eval/corpus/README.md` Intake: when an issue becomes an entry, record
the issue URL in the entry's existing `notes`; when the issue is
deleted, remove every entry that cites it. No schema change. No current
`public.jsonl` entry came from a feedback issue.

Stacked on #52; merge that first.

## Does this change what Reviso says to people?

- [x] No, this doesn't affect review output
- [ ] Yes — eval results below

## Checklist

- [x] Commits are signed off (`git commit -s`) — see
[CONTRIBUTING.md](../CONTRIBUTING.md#sign-your-commits-off-dco)
- [x] One concern per PR
- [x] Docs updated if behaviour changed

Validation: markdownlint-cli2 and lychee (CI args) pass, as do the
portability, matcher and gold-judge tests.

Signed-off-by: Michael Hohlios <michael@vyttle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant