Repository navigation
Delete derived eval cases with their source feedback issue - #53
Merged
MHohlios merged 1 commit intoOct 20, 2026
Conversation
State in the feedback contract that eval cases derived from an issue are deleted with it, and that git history keeps earlier commits. Record the source issue in an entry's notes so Intake can say when to remove it, and repoint the contract's pipeline link at the corpus Intake section. Signed-off-by: Michael Hohlios <michael@vyttle.com>
MHohlios
force-pushed
the
wiffletree/delete-derived-eval-cases-with-their-source-feed
branch
from
October 20, 2026 20:41
bba70f3 to
9b72bbf
Compare
MHohlios
deleted the
wiffletree/delete-derived-eval-cases-with-their-source-feed
branch
October 20, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follows #52, which added a Retention section to the feedback contract and left one question open: an eval case built from a feedback issue would outlive the issue we promise to delete. Decision: derived eval cases are deleted with their source issue.
skills/reviso/references/contracts/feedback.md): derived cases are deleted with the issue, from the public and private corpora alike. Removing an entry does not rewrite git history, so earlier commits still contain it; the contract says so rather than promising a rewrite. Theeval-candidatepipeline link now points at the corpus intake notes instead ofdocs/evals.md, which never described that pipeline.eval/corpus/README.mdIntake: when an issue becomes an entry, record the issue URL in the entry's existingnotes; when the issue is deleted, remove every entry that cites it. No schema change. No currentpublic.jsonlentry came from a feedback issue.Stacked on #52; merge that first.
Does this change what Reviso says to people?
Checklist
git commit -s) — see CONTRIBUTING.mdValidation: markdownlint-cli2 and lychee (CI args) pass, as do the portability, matcher and gold-judge tests.