Skip to content

Delete derived eval cases with their source feedback issue - #53

Merged
MHohlios merged 1 commit into
wiffletree/record-feedback-issue-retention-in-the-feedbackfrom
wiffletree/delete-derived-eval-cases-with-their-source-feed
Oct 20, 2026
Merged

MHohlios merged 1 commit into
wiffletree/record-feedback-issue-retention-in-the-feedbackfrom
wiffletree/delete-derived-eval-cases-with-their-source-feed

Conversation

@MHohlios

Copy link
Copy Markdown
Contributor

What and why

Follows #52, which added a Retention section to the feedback contract and left one question open: an eval case built from a feedback issue would outlive the issue we promise to delete. Decision: derived eval cases are deleted with their source issue.

  • Contract (skills/reviso/references/contracts/feedback.md): derived cases are deleted with the issue, from the public and private corpora alike. Removing an entry does not rewrite git history, so earlier commits still contain it; the contract says so rather than promising a rewrite. The eval-candidate pipeline link now points at the corpus intake notes instead of docs/evals.md, which never described that pipeline.
  • eval/corpus/README.md Intake: when an issue becomes an entry, record the issue URL in the entry's existing notes; when the issue is deleted, remove every entry that cites it. No schema change. No current public.jsonl entry came from a feedback issue.

Stacked on #52; merge that first.

Does this change what Reviso says to people?

  • No, this doesn't affect review output
  • Yes — eval results below

Checklist

  • Commits are signed off (git commit -s) — see CONTRIBUTING.md
  • One concern per PR
  • Docs updated if behaviour changed

Validation: markdownlint-cli2 and lychee (CI args) pass, as do the portability, matcher and gold-judge tests.

@MHohlios
MHohlios added this pull request to stack #54 October 20, 2026 20:41
State in the feedback contract that eval cases derived from an issue are
deleted with it, and that git history keeps earlier commits. Record the
source issue in an entry's notes so Intake can say when to remove it, and
repoint the contract's pipeline link at the corpus Intake section.

Signed-off-by: Michael Hohlios <michael@vyttle.com>
@MHohlios
MHohlios force-pushed the wiffletree/delete-derived-eval-cases-with-their-source-feed branch from bba70f3 to 9b72bbf Compare October 20, 2026 20:41
@MHohlios
MHohlios merged commit 844483f into main Oct 20, 2026
2 checks passed
@MHohlios
MHohlios deleted the wiffletree/delete-derived-eval-cases-with-their-source-feed branch October 20, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant