Skip to content

Link WebSocket transport into native engine white-box tests - #911

Merged
wieslawsoltes merged 1 commit into
fix/macos12-floating-charconv-908from
fix/native-websocket-fixture-link-910
Sep 22, 2026
Merged

wieslawsoltes merged 1 commit into
fix/macos12-floating-charconv-908from
fix/native-websocket-fixture-link-910

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem and result

Once PR #909's macOS 12 floating-conversion fix let NuGet Build osx-arm64 compile, the job exposed a latent linker failure: webscene_native_engine_tests calls native_websocket_transport from its white-box WebSocket fairness fixture, but the class's implementation was compiled only into the production shared library with restricted C++ exports. The test target now compiles webscene_native_websocket.cpp directly, as it already does for its DOM fixture, so the test links without broadening the engine ABI.

Validation and stack

  • Source review: the target already links ixwebsocket; the new source is the only implementation of the missing class methods and is confined to the test executable. git diff --check passes.
  • The updated top commit 10d9b939 adds a dedicated webscene_native_websocket_file_reader CTest filter. It must link and run cross-socket fairness, browser WebSocket, and FileReader behavior on macOS 12 before merge. This CI job is the complete gate because the cleaned local SDK/V8 cache is intentionally absent.
  • GitHub stack #912: bottom PR Restore macOS 12 native form conversion and package CI #909 (macOS 12 floating conversion), this top PR Link WebSocket transport into native engine white-box tests #911 (test link). Validate the top, then merge the ready stack atomically.

Closes #910.

The first full package build after the link fix compiled and linked 91 tests and passed 84; seven broader runtime tests failed (details are being triaged separately). The new focused CTest isolates this PR’s required behavior.

@wieslawsoltes wieslawsoltes changed the title Link WebSocket white-box transport in native engine tests Link WebSocket transport into native engine white-box tests Sep 22, 2026
@wieslawsoltes
wieslawsoltes force-pushed the fix/native-websocket-fixture-link-910 branch from 10d9b93 to c722b5d Compare September 22, 2026 06:37
@wieslawsoltes
wieslawsoltes merged commit 8c90c5c into main Sep 22, 2026
14 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link native WebSocket transport into white-box engine tests

1 participant