Repository navigation
Link WebSocket transport into native engine white-box tests - #911
Merged
wieslawsoltes merged 1 commit intoSep 22, 2026
Merged
wieslawsoltes merged 1 commit into
wieslawsoltes merged 1 commit into
Conversation
wieslawsoltes
force-pushed
the
fix/native-websocket-fixture-link-910
branch
from
September 22, 2026 06:37
10d9b93 to
c722b5d
Compare
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Once PR #909's macOS 12 floating-conversion fix let NuGet
Build osx-arm64compile, the job exposed a latent linker failure:webscene_native_engine_testscallsnative_websocket_transportfrom its white-box WebSocket fairness fixture, but the class's implementation was compiled only into the production shared library with restricted C++ exports. The test target now compileswebscene_native_websocket.cppdirectly, as it already does for its DOM fixture, so the test links without broadening the engine ABI.Validation and stack
ixwebsocket; the new source is the only implementation of the missing class methods and is confined to the test executable.git diff --checkpasses.10d9b939adds a dedicatedwebscene_native_websocket_file_readerCTest filter. It must link and run cross-socket fairness, browser WebSocket, and FileReader behavior on macOS 12 before merge. This CI job is the complete gate because the cleaned local SDK/V8 cache is intentionally absent.Closes #910.
The first full package build after the link fix compiled and linked 91 tests and passed 84; seven broader runtime tests failed (details are being triaged separately). The new focused CTest isolates this PR’s required behavior.