Skip to content

Restore macOS 12 NuGet package CI for floating form serialization #908

Closed

Description

@wieslawsoltes

Reproduction

WebScene main has repeatedly failed the NuGet packages / Build osx-arm64 job (for example runs 35585510953, 35581500980, and 35574320848). Focused PR #907 reproduced the same failure in run 35692037242, while its related CI, contracts, and portable V8 checks passed. The package lane compiles for macOS 12.0, but experiments/WebScene.NativeEngine.Probe/native/webscene_native_form_state.h uses floating-point std::from_chars at line 117 (annotated available only from macOS 26.0) and floating-point std::to_chars at lines 358 and 430 (available only from macOS 13.3). The compiler stops before package tests or artifacts are produced. This predates #907 and is not a CSS regression.

Proposed fix and acceptance

Keep the macOS 12 deployment target. Provide a locale-independent, finite-only floating parse/format implementation for targets where libc++ floating charconv is unavailable; preserve numeric and time-input serialization semantics, shortest round-trip output where required, and integer charconv paths. Add focused number/range/time edge and locale tests, a compile/link gate at macOS 12, and a bounded performance comparison. Then rerun the NuGet osx-arm64 lane plus related native form and Code OSS acceptance checks. Do not raise the deployment target merely to make CI green.

Activity

  1. added
    bugSomething isn't working
    vscode-oss/plannedPlanned for the AppScene/WebScene VS Code OSS integration
    on Sep 22, 2026
  2. wieslawsoltes commented on Sep 22, 2026

    @wieslawsoltes
    CollaboratorAuthor

    22 Sep 2026 progress: PR #909 now compiles past the floating charconv availability failure in the macOS 12 NuGet lane. The same job then exposed a separate webscene_native_engine_tests WebSocket white-box linker failure; that is #910 / PR #911, now the top of GitHub stack #912. The top package job will validate both before an atomic stack merge. The focused macOS 12 conversion test and its performance/equivalence checks passed locally.

  3. added
    vscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration
    and removed
    vscode-oss/plannedPlanned for the AppScene/WebScene VS Code OSS integration
    on Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvscode-oss/mergedMerged for the AppScene/WebScene VS Code OSS integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions