Repository navigation
Retain terminal storage flush after lifecycle disposal - #885
Merged
Merged
Conversation
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #884. Parent acceptance epic: #269.
VS Code emits its final storage state during
beforeunload, schedules a zero-delay flush, then synchronously disposes its Delayer and clears that handle. WebScene therefore publishedpagehidebefore the callback could start its IndexedDB transaction. This retains only zero-delay one-shot callbacks already accepted into the bounded terminal handoff when same-turn lifecycle disposal clears their public handles. Ordinary timers, delayed work, intervals, animation frames, and the existing 1,024-task ceiling keep their current behavior.The focused native fixture reproduces the exact VS Code sequence, fails before the runtime change, and now verifies callback/IndexedDB/continuation/pagehide order, restart durability, ordinary
clearTimeout, excluded future timers and intervals, and the bounded refill ceiling.Validation:
WEBSCENE_NATIVE_ENGINE_TEST_FILTER=terminal-indexeddb-navigation /private/tmp/webscene-882-build/webscene_native_engine_testsgit diff --check