Repository navigation
Defer terminal IndexedDB close behind storage flush - #886
Merged
Merged
Conversation
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the remaining exact-package race in #884; parent acceptance epic #269.
After PR #885 retained VS Code's same-turn canceled terminal flush callback, repeated package runs showed that its shutdown microtask could still call
IDBDatabase.close()before the callback started its transaction. This queues only a close requested from the active terminal lifecycle while accepted persistence work remains. The retained flush runs first, its transaction and descendants commit, then the connection closes beforepagehideand host handoff. Normal close calls remain synchronous.The focused fixture now reproduces
beforeunload→ canceled retained flush + shutdown-microtask close and verifies close request → flush → commit → continuation → pagehide order, restart durability, ordinary timer cancellation, excluded delayed work, and the existing 1,024-task bound.Validation:
WEBSCENE_NATIVE_ENGINE_TEST_FILTER=terminal-indexeddb-navigation /private/tmp/webscene-882-build/webscene_native_engine_testsgit diff --check